-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Enhancement] Add IcebergDeleteSink to support delete operations on Iceberg tables #67277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Youngwb
wants to merge
2
commits into
StarRocks:main
Choose a base branch
from
Youngwb:sink_fe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+344
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 54 / 59 (91.53%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
|
@cursor review |
fe/fe-core/src/main/java/com/starrocks/planner/IcebergDeleteSink.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/planner/IcebergDeleteSink.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/planner/IcebergDeleteSink.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Why I'm doing:
#66944
What I'm doing:
This pull request introduces support for delete operations on Iceberg tables by adding a new
IcebergDeleteSinkclass, its associated serialization logic, and comprehensive unit tests. The main focus is on enabling the planner to write position delete files to Iceberg tables, ensuring correct tuple validation and integration with the existing data sink infrastructure.Iceberg Delete Sink Implementation:
IcebergDeleteSinkclass infe/fe-core/src/main/java/com/starrocks/planner/IcebergDeleteSink.javato support delete operations for Iceberg tables, including tuple validation, configuration handling, and Thrift serialization.TDataSinkTypeenum ingensrc/thrift/DataSinks.thriftto include the newICEBERG_DELETE_SINKtype for proper Thrift serialization and planner integration.Testing and Validation:
fe/fe-core/src/test/java/com/starrocks/planner/IcebergDeleteSinkTest.javato verify tuple validation, Thrift serialization, and explain string output for the new sink.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Iceberg delete sink
IcebergDeleteSink(fe/fe-core/.../IcebergDeleteSink.java) to write Iceberg position delete files; validates tuple has_file(VARCHAR) and_pos(BIGINT), sets locations, compression, target file size, cloud config; provides explain output and Thrift serialization viaTDataSinkType.ICEBERG_DELETE_SINKintoTIcebergTableSink(usesdata_location,file_format=parquet).Thrift and tests
gensrc/thrift/DataSinks.thriftwithICEBERG_DELETE_SINK.IcebergDeleteSinkTest) covering tuple validation errors, Thrift serialization fields, andgetExplainString().Written by Cursor Bugbot for commit f63c4c7. This will update automatically on new commits. Configure here.