Skip to content

Commit ee8fc1d

Browse files
authored
Merge pull request #210 from StarRocks/review
review comment
2 parents 1093c72 + 4bea3ee commit ee8fc1d

2 files changed

Lines changed: 22 additions & 12 deletions

File tree

.github/workflows/ci-doc-translater.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
uses: actions/github-script@v7
3434
with:
3535
script: |
36-
github.rest.reactions.createForIssueComment({
36+
await github.rest.reactions.createForIssueComment({
3737
owner: context.repo.owner,
3838
repo: context.repo.repo,
3939
comment_id: context.payload.comment.id,

.github/workflows/ci-doc-translation-check.yml

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@ jobs:
1919
with:
2020
result-encoding: string
2121
script: |
22-
// If triggered by the Translation Runner, we can always proceed
23-
if (context.payload.workflow_run.name === 'Translation Runner') {
24-
return 'true';
25-
}
26-
2722
// Query the jobs of the CI DOC Checker run
2823
const { data: jobsData } = await github.rest.actions.listJobsForWorkflowRun({
2924
owner: context.repo.owner,
@@ -259,9 +254,24 @@ jobs:
259254
uses: actions/github-script@v7
260255
with:
261256
script: |
262-
github.rest.issues.addLabels({
263-
owner: context.repo.owner,
264-
repo: context.repo.repo,
265-
issue_number: ${{ steps.pr_number.outputs.pr_number }},
266-
labels: ['docs-maintainer']
267-
});
257+
try {
258+
await github.rest.issues.addLabels({
259+
owner: context.repo.owner,
260+
repo: context.repo.repo,
261+
issue_number: ${{ steps.pr_number.outputs.pr_number }},
262+
labels: ['docs-maintainer']
263+
});
264+
} catch (error) {
265+
const status = error?.status ?? error?.response?.status;
266+
const message = String(error?.message ?? '').toLowerCase();
267+
const hasAlreadyExistsCode = Array.isArray(error?.response?.data?.errors)
268+
&& error.response.data.errors.some(item => item?.code === 'already_exists');
269+
270+
// Ignore only idempotent duplicate-label errors; surface all other failures.
271+
if (status === 422 && (message.includes('already exists') || hasAlreadyExistsCode)) {
272+
core.info('docs-maintainer label already exists. Skipping.');
273+
return;
274+
}
275+
276+
throw error;
277+
}

0 commit comments

Comments
 (0)