Merge pull request #37 from StartAutomating/gittingRidOfErrors

GittingRidOfErrors

Author: StartAutomating

CHANGELOG.md

@@ -1,9 +1,15 @@
+## 0.1.7:
+* Use-Git: -Verbose no longer infers --verbose (#10)
+* Out-Git: Support for extension caching (#35)
+* Out-Git: Using -ErrorAction Ignore when -Verbose is not passed (#36)
+* Get-UGitExtension:  Updating Piecemeal Version [0.2.1].  (Re #32 #36)
+---
+
 ## 0.1.6
 * Adding support / formatting for git pull (#26)
 * Out-Git:  Extension Improvements (#33)
 ---
 
-
 ## 0.1.5
 * Adding git.log .Checkout() and Revert() (#27, #28)
 * Fixing formatting for git diff (#25)

Extensions/Git.Pull.UGit.Extension.ps1

@@ -2,38 +2,19 @@
 .SYNOPSIS
     git pull extension
 .DESCRIPTION
-
+    Returns git pull as objects.
 .EXAMPLE
     git pull
 #>
 [Management.Automation.Cmdlet("Out", "Git")]
-[ValidatePattern("^git (?>pull|fetch)")]
+[ValidatePattern("^git pull")]
 [OutputType('git.pull.fastforward', 'git.pull.nochange')]
 param(
 [Parameter(ValueFromPipeline)]
 [string]
 $GitOut
 )
 
-<#
-From https://github.com/StartAutomating/RoughDraft
-   432138e..9df4f8d  main       -> origin/main
- * [new tag]         v0.3.1     -> v0.3.1
-Updating 432138e..9df4f8d
-Fast-forward
- CHANGELOG.md                                    |  13 ++-
- Convert-Media.ps1                               |  37 +++++++--
- Edit-Media.ps1                                  |  95 ++++++++++++++-------
- Extension/DrawSubtitle.RoughDraft.Extension.ps1 |  78 ++++++++++++++++++
- Extension/Resize.RoughDraft.Extension.ps1       |  11 ++-
- Extension/Subtitler.RoughDraft.Extension.ps1    | 105 ++++++++++++++++++++++++
- RoughDraft.psd1                                 |  13 ++-
- Show-Media.ps1                                  |   2 +-
- 8 files changed, 309 insertions(+), 45 deletions(-)
- create mode 100644 Extension/DrawSubtitle.RoughDraft.Extension.ps1
- create mode 100644 Extension/Subtitler.RoughDraft.Extension.ps1
-#>
-
 begin {
     $pullLines = @()
 }

Get-UGitExtension.ps1

@@ -54,25 +54,48 @@
         # First, we need to determine what the combined git command was.
         # Luckily, this is easy:  just combine "git" with the list of git argument
         $gitCommand = @('git') + $GitArgument[0..$GitArgument.Length] -join ' '
-        # Now that we have that, let's initialize an empty variable to keep any extension validation errors.
-        $extensionValidationErrors = $null
-        # Then we create a hashtable containing the parameters to Get-UGitExtension:
-        $uGitExtensionParams = @{
-                CommandName   = $MyInvocation.MyCommand      # We want extensions for this command
-                ValidateInput = $gitCommand                  # that are valid, given $GitCommand.
-                ErrorAction   = 'SilentlyContinue'           # We do not want to display errors
-                ErrorVariable = 'extensionValidationErrors'  # we want to redirect them into $extensionValidationErrros.
+
+        # Now we need to see if we have have a cached for extension mapping.
+        if (-not $script:GitExtensionMappingCache) {
+            $script:GitExtensionMappingCache = @{} # If we don't, create one.
         }
-        # Now we get a list of git output extensions
-        $gitOutputExtensions = @(Get-UGitExtension @uGitExtensionParams)
-        # If any of them had errors, and we want to see the -Verbose channel
-        if ($extensionValidationErrors -and $VerbosePreference -ne 'silentlyContinue')  {
-            foreach ($validationError in $extensionValidationErrors) {
-                Write-Verbose "$validationError" # write the validation errors to verbose.
-                # It should be noted that there will almost always be validation errors,
-                # since most extensions will not apply to a given $GitCommand
+
+        if (-not $script:GitExtensionMappingCache[$gitCommand]) { # If we don't have a cached extension list
+
+            # let's initialize an empty variable to keep any extension validation errors.
+            $extensionValidationErrors = $null
+            # Then we create a hashtable containing the parameters to Get-UGitExtension:
+            $uGitExtensionParams = @{
+                    CommandName   = $MyInvocation.MyCommand      # We want extensions for this command
+                    ValidateInput = $gitCommand                  # that are valid, given $GitCommand.
+                    
             }
-        }
+
+            # If -Verbose is -Debug is set, we will want to populate extensionValidationErrors
+            if ($VerbosePreference -ne 'silentlyContinue' -or 
+                $DebugPreference -ne 'silentlyContinue') {
+                $uGitExtensionParams.ErrorAction   = 'SilentlyContinue'           # We do not want to display errors
+                $uGitExtensionParams.ErrorVariable = 'extensionValidationErrors'  # we want to redirect them into $extensionValidationErrors.
+                $uGitExtensionParams.AllValid      = $true                        # and we want to see that all of the validation attributes are correct.
+            } else {
+                $uGitExtensionParams.ErrorAction = 'Ignore'
+            }
+
+            # Now we get a list of git output extensions and store it in the cache.
+            $script:GitExtensionMappingCache[$gitCommand] = $gitOutputExtensions = @(Get-UGitExtension @uGitExtensionParams)
+
+            # If any of them had errors, and we want to see the -Verbose channel
+            if ($extensionValidationErrors -and $VerbosePreference -ne 'silentlyContinue')  {
+                foreach ($validationError in $extensionValidationErrors) {
+                    Write-Verbose "$validationError" # write the validation errors to verbose.
+                    # It should be noted that there will almost always be validation errors,
+                    # since most extensions will not apply to a given $GitCommand
+                }
+            }
+        } else {
+            # If there was already an extension cached, we can skip the previous steps and just reuse the cached extensions.
+            $gitOutputExtensions = $script:GitExtensionMappingCache[$gitCommand]
+        }        
 
         # Next we want to create a collection of SteppablePipelines.
         # These allow us to run the begin/process/end blocks of each Extension.

Out-Git.ps1

@@ -67,6 +67,7 @@ Get-UGitExtension is built using [Piecemeal](https://github.com/StartAutomating/
 * git diff
 * git log
 * git push
+* git pull
 * git status
 
 

README.md

@@ -87,10 +87,6 @@
             $argumentNumber++
         }
 
-        if ($VerbosePreference -ne 'silentlyContinue' -and -not ($GitArgument -eq '-v'))
-        { 
-            $GitArgument += '--verbose' # they probably want --verbose (and enough git commands support it to try).
-        }
         $progId = Get-Random
         $dirCount = 0
         $RepoNotRequired = 'clone','init'  # A small number of git operations do not require a repo.  List them here.

Use-Git.ps1

@@ -1,5 +1,5 @@
 @{
-    ModuleVersion    = '0.1.6'
+    ModuleVersion    = '0.1.7'
     RootModule       = 'ugit.psm1'
     FormatsToProcess = 'ugit.format.ps1xml'
     TypesToProcess   = 'ugit.types.ps1xml'
@@ -16,6 +16,13 @@ PrivateData   = @{
         ProjectURI = 'https://github.com/StartAutomating/ugit'
         LicenseURI = 'https://github.com/StartAutomating/ugit/blob/main/LICENSE'
         ReleaseNotes = @'
+## 0.1.7:
+* Use-Git: -Verbose no longer infers --verbose (#10)
+* Out-Git: Support for extension caching (#35)
+* Out-Git: Using -ErrorAction Ignore when -Verbose is not passed (#36)
+* Get-UGitExtension:  Updating Piecemeal Version [0.2.1].  (Re #32 #36)
+---
+
 ## 0.1.6
 * Adding support / formatting for git pull (#26)
 * Out-Git:  Extension Improvements (#33)