#1724 AddDescriptiveFixInstructionsForInvalidStartCampaign #1748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuyler1d
requested changes
Aug 24, 2020
|
Forgot to say: This is a very helpful addition!!! Let's get it in! |
…InvalidStartCampaign
…validStartCampaign
…ampaign' of https://github.com/nke5ka/Spoke into Issue1724-AddDescriptiveFixInstructionsForInvalidStartCampaign
Frydafly
added
the
S-waiting on author
engelhartrueben
added
the
S-work in progress (WIP)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1724
Description
Adds warning if twilio config is not setup. This may become less important or may need additional changes due to simultaneous changes to twilio default setup (fake service instead of twilio), or if twilio setup moves elsewhere (settings, or is otherwise streamlined). Additionally, possible changes may be warranted as the overarching error message currently refers to settings (which will not help at present) but is kept in case future errors dictate that settings is in fact the place to fix issues, or is sms setup is changed.
Checklist:
(Small change should not break anything, and does not have major impacts)