Feature Request: Set an expiration date on texterroles Redis keys

[crayolakat]

Problem
The texterroles Redis keys don't have an expiration date and stay in the cache forever.

Solution
It would be nice to have an expiration date so that old and outdated texterroles will get purged. Maybe 365 days?

[Arique1104]

Hey @crayolakat,

Where would this edit need to be? @ninesky00 is interested in working on this as a Backend Engineer. Got any pointers on where he could start?

[crayolakat]

@Arique1104 @ninesky00 Sorry I was on vacation and just got back today! Let me dig around and get back to you

[crayolakat]

The changes would be in the file src/server/models/cacheable_queries/user.js

If you look at line 124-129, you will see that the texterauth keys are set to expire after 12 hours (43,200 seconds):
https://github.com/MoveOnOrg/Spoke/blob/4538f006b7be658d378d09b5cbc33f5db15479b0/src/server/models/cacheable_queries/user.js#L124-L129

Lines 82-86 is where the texterroles keys are set:
https://github.com/MoveOnOrg/Spoke/blob/4538f006b7be658d378d09b5cbc33f5db15479b0/src/server/models/cacheable_queries/user.js#L82-L86

Notice that there is no .expire(...) method called in lines 82-86. For this feature request, you would need to add an .expire(...) to lines 82-86, similar to how it is in lines 124-L129.

[ninesky00]

Hello @crayolakat @Arique1104, sorry it took me so long to get to this. I made the following change a while ago.

However, I was trying to write a test for it. After some digging around, I wasn't able to find any tests for Redis in user.js, texter.test/texter.test.js, cacheable_queries/user.test.js, or test/test_helpers.js. I'm wondering if I should proceed as is. Also I was thinking if there is a necessity to expire the existing cache that currently has no expiration with EXPIRE NX -- Set expiry only when the key has no expiry or to override them with EXPIRE GT -- Set expiry only when the new expiry is greater than current one. Please let me know if you get a chance, thanks.