VSCode extractzip task has unintended results

[jurassicplayer]

decky-plugin-template/.vscode/tasks.json

Line 102 in 5a91054

"command": "echo '${config:deckdir}/homebrew/plugins/${config:pluginname}.zip' && ssh ${config:deckuser}@${config:deckip} -p ${config:deckport} ${config:deckkey} 'echo ${config:deckpass} | sudo -S mkdir 755 -p \"$(echo \"${config:deckdir}/homebrew/plugins/${config:pluginname}\" | sed \"s| |-|\")\" && echo ${config:deckpass} | sudo -S chown ${config:deckuser}:${config:deckuser} \"$(echo \"${config:deckdir}/homebrew/plugins/${config:pluginname}\" | sed \"s| |-|\")\" && echo ${config:deckpass} | sudo -S bsdtar -xzpf \"${config:deckdir}/homebrew/plugins/${config:pluginname}.zip\" -C \"$(echo \"${config:deckdir}/homebrew/plugins/${config:pluginname}\" | sed \"s| |-|g\")\" --strip-components=1 --fflags '",

• The mkdir command is making a ~/755 folder instead of making a new plugin folder with 755 permissions (needs the -m flag)
• The files are extracted blindly into the folder (nothing is removed). This can leave older files when deploying after reorganizing folders/files/filenames/etc.

[CarJem]

To add on top of this... I discovered another issue causing the following issue related to this
The sed command doesn't properly account for dashes when creating the folder for the destination to go into

 *  Executing task: echo '/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip' && ssh deck@steamdeck -p 22 -i /home/carjem/.ssh/id_rsa 'echo pass | sudo -S mkdir 755 -p "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|")" && echo pass | sudo -S chown deck:deck "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|")" && echo pass | sudo -S bsdtar -xzpf "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip" -C "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|g")" --strip-components=1 --fflags ' 

/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip
[sudo] password for deck: bsdtar: could not chdir to '/home/deck/homebrew/plugins/SPGM-WinTweaks-Intergration-Plugin'

[TrainDoctor]

@jurassicplayer I believe I have made changes that should help with your points on the extractzip-fix branch.
@CarJem I'll have another commit time permitting to help with that.

[TrainDoctor]

To add on top of this... I discovered another issue causing the following issue related to this The sed command doesn't properly account for dashes when creating the folder for the destination to go into

 *  Executing task: echo '/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip' && ssh deck@steamdeck -p 22 -i /home/carjem/.ssh/id_rsa 'echo pass | sudo -S mkdir 755 -p "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|")" && echo pass | sudo -S chown deck:deck "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|")" && echo pass | sudo -S bsdtar -xzpf "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip" -C "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|g")" --strip-components=1 --fflags ' 

/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip
[sudo] password for deck: bsdtar: could not chdir to '/home/deck/homebrew/plugins/SPGM-WinTweaks-Intergration-Plugin'

For reference, no plugin should have a name with spaces in it so in future I will aim to add support for handling dashes but I'm pretty sure it's a non-issue and the issue is spaces in the plugin name.