fixed spotbugs issue and provided test for FileBoolean

Author: StefanSpieker

core/src/main/java/jenkins/util/io/FileBoolean.java

@@ -7,7 +7,9 @@
 import java.nio.file.InvalidPathException;
 import java.util.logging.Level;
 import java.util.logging.Logger;
+
 import jenkins.model.Jenkins;
+import org.apache.commons.io.FilenameUtils;
 
 /**
  * Uses a presence/absence of a file as a persisted boolean storage.
@@ -29,7 +31,7 @@ public FileBoolean(File file) {
     }
 
     public FileBoolean(Class owner, String name) {
-        this(new File(Jenkins.get().getRootDir(), owner.getName().replace('$', '.') + '/' + name));
+        this(new File(Jenkins.get().getRootDir(), owner.getName().replace('$', '.') + '/' + FilenameUtils.getName(name)));
     }
 
     /**
@@ -39,6 +41,14 @@ public boolean get() {
         return state = file.exists();
     }
 
+    /**
+     * @return the getFilePath or empty string
+     */
+    public String getFilePath() {
+        if (file == null) return "";
+        return file.getAbsolutePath();
+    }
+
     /**
      * Like {@link #get()} except instead of checking the actual file, use the result from the last {@link #get()} call.
      */

core/src/spotbugs/excludesFilter.xml

@@ -399,7 +399,6 @@
           <Class name="jenkins.slaves.restarter.UnixSlaveRestarter"/>
           <Class name="jenkins.SoloFilePathFilter"/>
           <Class name="jenkins.util.groovy.GroovyHookScript"/>
-          <Class name="jenkins.util.io.FileBoolean"/>
           <Class name="jenkins.util.JavaVMArguments"/>
           <Class name="jenkins.util.SystemProperties"/>
           <Class name="jenkins.util.VirtualFile$FilePathVF"/>

test/src/test/java/jenkins/util/io/FileBooleanTest.java

@@ -0,0 +1,20 @@
+package jenkins.util.io;
+
+import java.io.File;
+import jenkins.model.Jenkins;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.jvnet.hudson.test.JenkinsRule;
+import org.jvnet.hudson.test.junit.jupiter.WithJenkins;
+
+@WithJenkins
+class FileBooleanTest {
+
+    @Test
+    void getFileName(JenkinsRule j) {
+        String path = j.jenkins.getRootDir().getAbsolutePath();
+        final String foo = new FileBoolean(Jenkins.class, "foo").getFilePath();
+        final String fooPath = String.join(File.separator, path, Jenkins.class.getName(), "foo");
+        Assertions.assertEquals(fooPath, foo);
+    }
+}