Skip to content

Commit becf06c

Browse files
theboycoderclaude
andauthored
fix(ledger): map gone-repos|repo-gone — it is world, not instrument (#1676)
A `gone-repos|repo-gone` row landed in the committed ledger with no KIND_OF mapping, so it fell to DEFAULT_KIND (instrument) and the parity test went red. That test gates the pre-push hook, so main currently refuses every push. It belongs in `world`. check-gone-repos writes the `gone` state ONLY when GitHub answers 404 to a direct read of the repository — rate limits, 5xx and a missing token all classify as unchecked and can never produce it. So the finding is a repository actually deleted upstream, which is the ecosystem moving past our record and the product doing its job. Reading it as `instrument` says our scanner broke, which is exactly the confusion that state was introduced to end. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 parent 0e396dc commit becf06c

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

src/lib/improvement-ledger.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -435,6 +435,11 @@ const KIND_OF: Record<string, FindingKind> = {
435435
"scf-crosscheck|scf-understated": "world", // …or more
436436
"scf-crosscheck|scf-round-overclaim": "world",
437437
"engine-d-demand|coverage-gap": "world", // real demand for a project we do not hold — a curation add
438+
// check-gone-repos writes `gone` ONLY on a direct GitHub 404; rate limits,
439+
// 5xx and a missing token classify as unchecked and can never produce it.
440+
// So this is the repository actually deleted upstream, not our scanner
441+
// failing — that distinction is the reason the state exists.
442+
"gone-repos|repo-gone": "world",
438443
// ── instrument: our measurement or serving broke ──
439444
"golden-eval|golden-fail": "instrument",
440445
"engine-a-recall|recall-miss": "instrument",

0 commit comments

Comments
 (0)