Merge pull request #570 from mbo-hub11/feature/issues-518-519-520-521

feat: implement issues #518-#521

Author: Kingsman-99

.gitignore

@@ -1,6 +1,8 @@
 # Build output
 target/
 *.wasm
+wasm32-unknown-unknown/
+**/wasm32-unknown-unknown/
 
 # Environment files
 .env
@@ -10,6 +12,7 @@ target/
 # OS files
 .DS_Store
 Thumbs.db
+desktop.ini
 .vscode/
 .idea/
 *.log
@@ -28,12 +31,16 @@ snapshots/
 *.swp
 *.swo
 *~
+*.sublime-project
+*.sublime-workspace
 
 # Test snapshots
 **/__snapshots__/
 *.snap
 **/test_snapshots/
 *.snapshot
+**/snapshots/
+*.snap.bak
 
 # Stellar CLI
 .stellar/
@@ -43,25 +50,52 @@ identity/
 # Logs
 *.log
 *.log.*
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
 
 # Coverage reports
 lcov.info
 tarpaulin-report.html
 coverage/
 .nyc_output/
+profdata/
 
 # Temporary files
 *.tmp
 *.bak
 *.orig
+*.rej
+*~
+.*.swp
+.*.swo
 
 # Node / JS tooling (if any frontend tooling is added)
 node_modules/
 dist/
 .pnp
 .pnp.js
 .yarn/
+.next/
+.nuxt/
+.parcel-cache/
+.cache/
 
 # Rust / Cargo artefacts not caught by target/
 **/*.rs.bk
 Cargo.lock.bak
+**/*.profraw
+**/*.profdata
+
+# Fuzz corpus (generated during fuzzing runs)
+fuzz/corpus/*
+!fuzz/corpus/.gitkeep
+
+# Cargo audit / deny / outdated cache
+.cargo-ok
+cargo-audit.toml
+
+# Python / misc tooling
+__pycache__/
+*.pyc
+.pytest_cache/

contracts/split/src/error.rs

@@ -80,6 +80,10 @@ pub enum ContractError {
     CircularDependency = 45,
     /// Issue #453: Source contract has exceeded its call rate limit within the current window.
     SourceContractRateLimited = 46,
+    /// Issue #519: An invoice status transition is not permitted by the state machine.
+    InvalidStateTransition = 47,
+    /// Issue #518: A split ratio is invalid (e.g. >= denominator or sum mismatch).
+    InvalidRatio = 48,
     /// Storage migration framework: `schema_version` is behind the version
     /// this Wasm build expects. Call `migrate` before retrying.
     MigrationRequired = 47,

contracts/split/src/events.rs

@@ -1,4 +1,4 @@
-use crate::types::{DisputeOutcome, InvoiceStatus, RepScore, TimelockAction};
+use crate::types::{DisputeOutcome, FeeSplit, InvoiceStatus, RepScore, TimelockAction};
 use soroban_sdk::{contracttype, symbol_short, Address, BytesN, Env, String, Vec};
 
 // ---------------------------------------------------------------------------
@@ -906,7 +906,19 @@ pub fn dispute_expired(env: &Env, invoice_id: u64) {
     );
 }
 
+/// Issue #521: Emitted when the fee recipients list is updated.
+pub fn fee_recipients_updated(env: &Env, recipients: &Vec<FeeSplit>) {
+    env.events().publish(
+        (
+            symbol_short!("split"),
+            symbol_short!("fee_rcp_upd"),
+        ),
+        (recipients.clone(),),
+    );
+}
+
 /// Issue #326: Emitted when a protocol fee is paid to treasury on release.
+///
 /// Topics: (split, fee_paid, invoice_id)
 /// Data: (amount, treasury, ledger)
 pub fn fee_paid(env: &Env, invoice_id: u64, amount: i128, treasury: &Address) {