Merge pull request #32 from Lostmyname/refund-notification-fix

Fix for state machine errors after refunding in Adyen interface

Author: Dkendal

app/models/spree/adyen/notification_processor.rb

@@ -72,7 +72,7 @@ def handle_modification_event
             refund_reason_id: ::Spree::RefundReason.first.id # FIXME
           )
           # payment was processing, move back to completed
-          payment.complete!
+          payment.complete! unless payment.completed?
           notification.processed!
         end
       end

spec/models/spree/adyen/notification_processor_spec.rb

@@ -146,23 +146,37 @@
     end
 
     context "when event is REFUND" do
-      include_examples "processed event"
+      shared_examples "refund" do
+        let(:event_type) { :refund }
+        it "creates a refund" do
+          expect { subject }.
+            to change { payment.reload.refunds.count }.
+            from(0).
+            to(1)
+        end
+      end
 
-      let(:event_type) { :refund }
-      let(:payment_state) { "processing" }
+      context "when refunded from Solidus" do
+        let(:payment_state) { "processing" }
+        include_examples "refund"
 
-      it "creates a refund" do
-        expect { subject }.
-          to change { payment.reload.refunds.count }.
-          from(0).
-          to(1)
+        it "changes the payment state to completed" do
+          expect { subject }.
+            to change { payment.reload.state }.
+            from("processing").
+            to("completed")
+        end
       end
 
-      it "changes the payment state to completed" do
-        expect { subject }.
-          to change { payment.reload.state }.
-          from("processing").
-          to("completed")
+      context "when refunded from Adyen" do
+        let(:payment_state) { "completed" }
+        include_examples "refund"
+
+        it "does not change the payment state" do
+          expect { subject }.
+            not_to change { payment.reload.state }.
+            from("completed")
+        end
       end
     end