Skip to content

Double instantiation of Os::Log logger #15

@legounicycler

Description

@legounicycler

Very small issue here, but I recently discovered that there is a double instantiation of the Os::Log class.

The first instantiation is found in the Main.cpp file for Arduino deployments on line 52, right after the #ifdef statement setting up the Serial logger.

Os::Log logger;

The second instantiation is found in the Topology.cpp file on line 38 after the enum of context ID's. This one

Os::Log osLogger;

This one probably goes all the way back to the Ref deployment.

While this double instantiation doesn't affect anything negatively, you can safely remove either of these instantiations without any effect on the functionality of the particular instance of the Fw::Logger that's currently registered. Happy to discuss this more, but I've run out of time for now and just wanted to get this written down initially.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions