Skip to content

Commit 4e63a68

Browse files
authored
Exclude Internal API User from Total User Count (#3299)
# Description of Changes Please provide a summary of the changes, including: - **What was changed**: Modified the `getTotalUsersCount()` method in `UserService` to subtract one user from the count if the internal API user is present in the database. This ensures that the internal service account does not skew user metrics. - **Why the change was made**: To prevent the internal API user (used for backend operations) from being included in total user statistics, which should reflect only real user accounts. --- ## Checklist ### General - [x] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [x] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md) (if applicable) - [x] I have performed a self-review of my own code - [x] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#6-testing) for more details.
1 parent b28cabe commit 4e63a68

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

Diff for: src/main/java/stirling/software/SPDF/config/security/UserService.java

+7-1
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,12 @@ public void syncCustomApiUser(String customApiKey) {
475475

476476
@Override
477477
public long getTotalUsersCount() {
478-
return userRepository.count();
478+
// Count all users in the database
479+
long userCount = userRepository.count();
480+
// Exclude the internal API user from the count
481+
if (findByUsernameIgnoreCase(Role.INTERNAL_API_USER.getRoleId()).isPresent()) {
482+
userCount -= 1;
483+
}
484+
return userCount;
479485
}
480486
}

0 commit comments

Comments
 (0)