Fix/deeplink from webview for android (coinbase#1121)

pedrorosarioo · cb-pedro-rosario · web-flow · commit c57516aa352a · 2024-02-23T20:03:36.000-08:00
* fix: anchor tag approach to cover both iOS and Android cases

* fix: add expected target

---------

Co-authored-by: Pedro Rosario &lt;pedro.rosario@coinbase.com&gt;
diff --git a/packages/wallet-sdk/src/relay/mobile/MobileRelayUI.ts b/packages/wallet-sdk/src/relay/mobile/MobileRelayUI.ts
@@ -32,8 +32,11 @@ export class MobileRelayUI implements RelayUI {
       url.searchParams.append('wl_url', walletLinkUrl);
     }
 
-    window.location.href = url.href;
-
+    const anchorTag = document.createElement('a');
+    anchorTag.target = 'cbw-opener';
+    anchorTag.href = url.href;
+    anchorTag.rel = 'noreferrer noopener';
+    anchorTag.click();
   }
 
   openCoinbaseWalletDeeplink(walletLinkUrl?: string): void {

Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,11 @@ export class MobileRelayUI implements RelayUI {`
`32`	`32`	`url.searchParams.append('wl_url', walletLinkUrl);`
`33`	`33`	`}`
`34`	`34`
`35`		`- window.location.href = url.href;`
`36`		`-`
	`35`	`+ const anchorTag = document.createElement('a');`
	`36`	`+ anchorTag.target = 'cbw-opener';`
	`37`	`+ anchorTag.href = url.href;`
	`38`	`+ anchorTag.rel = 'noreferrer noopener';`
	`39`	`+ anchorTag.click();`
`37`	`40`	`}`
`38`	`41`
`39`	`42`	`openCoinbaseWalletDeeplink(walletLinkUrl?: string): void {`