Subathon timer fails to add multiple subs correctly

[ChibiAcer]

There seems to be an issue where the subathon timer widget fails to correctly add time when multiple subs are gifted at once. If it's set to add 1 minute per sub, when someone gifts 5 at once, sometimes it only adds 1 or 2 minutes to the timer.

Reviewing the footage, I've seen instances where the time is being added, it suddenly goes back down, then adds again. I suspect the problem is that when multiple subs come in simultaneously they're overwriting each other. The function handle_activityReceived runs async, but when multiple events arrive at once they're not waiting for each other to finish adding to the timer before triggering. So if the timer currently ends at 10:00, multiple triggers will say, "Add 1 minute to 10:00, the time should now be 10:01".

I think the solution is to modify the addTime expressions under subathon/widget-main.js, line 215, 219, and 223.

From:
if (isInt(str) && managedData.timeAdditions.t1[0]) addTime(parseInt(str, 10));
To:
if (isInt(str) && managedData.timeAdditions.t1[0]) await addTime(parseInt(str, 10));

Unfortunately, I'm only a stream moderator, not a streamer, so I'm having difficulty testing the code firsthand. I'm also not heavily practiced with JavaScript and asynchronous code.

[Jusubox]

I flagged to them about this issue a while back (months ago) on their discord and they were aware, months later that bug is still on their live widget. and it seems like there's just a lack of support for their own widget currently. the issue doesn't just depend on that incorrect structure,

But also if (activity.bulkGifted) { // Ignore gifting event and count only real subs no idea why its ignoring during a subathon timer widget?

it's just disappointing cause there's so much streamers out there who is using this widget and aren't aware that they are missing so much time on their subathon timer until the mods take over, and its not even their fault to begin with 🤷‍♂️

[ChibiAcer]

Was kind of worried about that. Maybe I'll try to learn StreamElements to test it myself, and maybe fork this code if they don't fix it.

Regarding if (activity.bulkGifted) { // Ignore gifting event and count only real subs , I think that's correct the way it's tracking subs. When a multi-sub bomb is dropped, it creates an event entry in the Discord chat for the "so-and-so gifted x subs!", but then also still creates a sub event entry for each individual sub. If it didn't ignore the bulk gift event, it would end up tracking them twice.

I originally wrote my own code in a separate program to log subs (as a workaround for the SE widget not working), and at first I only tracked the bulk gift event. The downside to doing it that way is it then completely misses if someone gifts a sub to a specific individual (compared to gifting random subs to the community).