generate-certificate-database.sh: not found - replace `script` with `shell` in l2tp role

[joejag]

Version: 5275d6a

I'm trying to create an instance on EC2. I've ran ./streisland twice and each time I get the same error due to a script being missing:

TASK [l2tp-ipsec : Generate a certificate database file] *********************** fatal: [52.56.196.137]: FAILED! => {"changed": true, "failed": true, "rc": 127, "stderr": "Shared connection to 52.56.X.X closed.\r\n", "stdout": "\r\n/bin/sh: 1: /home/ubuntu/.ansible/tmp/ansible-tmp-1488971080.67-13304927825093/generate-certificate-database.sh: not found\r\n", "stdout_lines": ["", "/bin/sh: 1: /home/ubuntu/.ansible/tmp/ansible-tmp-1488971080.67-13304927825093/generate-certificate-database.sh: not found"]}

Is this a bug?

[cpu]

@joejag - is this still affecting you with the tip of master?

[joejag]

Tried again and same failure. EC2 London if it helps. But it looks like a file is missing:

TASK [l2tp-ipsec : Generate a certificate database file] *********************** fatal: [X.X.X.X]: FAILED! => {"changed": true, "failed": true, "rc": 127, "stderr": "Shared connection to X.X.X.X closed.\r\n", "stdout": "\r\n/bin/sh: 1: /home/ubuntu/.ansible/tmp/ansible-tmp-1491856148.6-240723434924012/generate-certificate-database.sh: not found\r\n", "stdout_lines": ["", "/bin/sh: 1: /home/ubuntu/.ansible/tmp/ansible-tmp-1491856148.6-240723434924012/generate-certificate-database.sh: not found"]}

SHA: 1b1a9bda65c0a1a695744716d396294ae85dadb8

[CorbanR]

I have experienced a similar error with ec2 instances (albiet not this one specifically) due to an Ansible bug. I submmited a PR which may help. Specifically this change

https://github.com/jlund/streisand/pull/593/files/72d61e3e4137153ea59eb30b34af656f33aa2a21..7088dd1e5f7a89cfdbf73ff47477d26045d53326#diff-0485be50e14d7e6644f184d2d75f7d3c

@joejag if you could check out the PR and test, or grab latest https://github.com/CorbanR/streisand master it may fix your issues.

[joejag]

I've tried with the patch and I'm seeing the same results.

It seems this is something to do with using the Ansible script module (as used in the l2tp-ipsec playbook).

I'm using Ansible 2.2.1.0. Which Streisand has a workaround in place for in the ansible.cfg. Which links to an open Ansible issue to do with copying files across: 21562

I'll wait until Ansilble fix that core issue then retry installing Streisand.

[nihaopaul]

same bug, just grabbed from master, if i switch from script: to shell: and append the script commands inside this line it gets past this error.

ansible version 2.3.0.0

[cpu]

Seems like the script should be switched to shell in the short term.