Skip to content

fix(streams): stream url not available without server #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kKaskak wants to merge 2 commits into
base: development
Choose a base branch
from
Open

fix(streams): stream url not available without server #906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2713232
fix: stream url not available without server
kKaskak Dec 31, 2025
2757132
chore: fmt & clippy
kKaskak Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/deep_links/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ use crate::{
library::LibraryItem,
profile::Settings,
query_params_encode,
resource::{MetaItem, MetaItemPreview, Stream, StreamUrls, Video},
resource::{
get_download_url_from_source, MetaItem, MetaItemPreview, Stream, StreamUrls, Video,
},
streams::{ConvertedStreamSource, StreamsItem},
},
};
Expand Down Expand Up @@ -77,7 +79,8 @@ impl From<(&Stream, Option<&Url>, &Settings)> for ExternalPlayerLink {
.map(|converted| StreamUrls::new(converted, streaming_server_url));
let download = stream_urls
.as_ref()
.and_then(|urls| urls.download_url.as_ref().map(ToString::to_string));
.and_then(|urls| urls.download_url.as_ref().map(ToString::to_string))
.or_else(|| get_download_url_from_source(stream).map(|url| url.to_string()));
let streaming = stream_urls
.as_ref()
.and_then(|urls| urls.streaming_url.clone());
Expand Down
60 changes: 60 additions & 0 deletions src/types/resource/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,6 +1165,66 @@ fn get_download_url(
}
}

/// generate url from source without conversion (no server running)
pub fn get_download_url_from_source(stream: &Stream) -> Option<Url> {
match &stream.source {
StreamSource::Url { url } => Some(url.clone()),
StreamSource::Torrent {
info_hash,
announce,
..
} => {
// generate magnet from torrent info
let trackers = announce
.iter()
.map(|tracker| {
tracker
.strip_prefix("tracker:")
.map(ToString::to_string)
.unwrap_or_else(|| tracker.to_owned())
})
.map(|tracker| {
tracker
.strip_prefix("dht:")
.map(ToString::to_string)
.unwrap_or_else(|| tracker.to_owned())
})
.map(|tracker| utf8_percent_encode(&tracker, URI_COMPONENT_ENCODE_SET).to_string())
.collect::<Vec<String>>();
let trackers = if !trackers.is_empty() {
Some(format!("&tr={}", trackers.join("&tr=")))
} else {
None
};

format!(
"magnet:?{dn}xt=urn:btih:{hash}{trackers}",
dn = if let Some(name) = stream.name.as_ref() {
format!(
"dn={}&",
utf8_percent_encode(name, URI_COMPONENT_ENCODE_SET)
)
} else {
String::new()
},
hash = hex::encode(info_hash),
trackers = trackers.unwrap_or_default(),
)
.parse()
.ok()
}
StreamSource::YouTube { yt_id } => format!(
"https://youtube.com/watch?v={}",
utf8_percent_encode(yt_id, URI_COMPONENT_ENCODE_SET)
)
.parse()
.ok(),
StreamSource::External { external_url, .. } => external_url.clone(),
StreamSource::PlayerFrame { player_frame_url } => Some(player_frame_url.clone()),
_ => None,
}
}

fn get_streaming_url(converted: &Stream<ConvertedStreamSource>) -> Option<Url> {
match &converted.source {
ConvertedStreamSource::Url { url } if url.scheme() == "magnet" => None,
Expand Down