Skip to content

Commit 73d3a1c

Browse files
committed
revert non-objdet changes
1 parent 211c435 commit 73d3a1c

6 files changed

Lines changed: 17 additions & 8 deletions

File tree

src/valor_lite/classification/manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
unpack_confusion_matrix_into_metric_list,
1717
unpack_precision_recall_rocauc_into_metric_lists,
1818
)
19-
from valor_lite.exceptions import EmptyCacheError, EmptyFilterError
19+
from valor_lite.exceptions import EmptyEvaluatorError, EmptyFilterError
2020

2121
"""
2222
Usage
@@ -515,7 +515,7 @@ def finalize(self):
515515
A ready-to-use evaluator object.
516516
"""
517517
if self._detailed_pairs.size == 0:
518-
raise EmptyCacheError()
518+
raise EmptyEvaluatorError()
519519

520520
self._label_metadata = compute_label_metadata(
521521
ids=self._detailed_pairs[:, :3].astype(np.int32),

src/valor_lite/semantic_segmentation/manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from numpy.typing import NDArray
55
from tqdm import tqdm
66

7-
from valor_lite.exceptions import EmptyCacheError, EmptyFilterError
7+
from valor_lite.exceptions import EmptyEvaluatorError, EmptyFilterError
88
from valor_lite.semantic_segmentation.annotation import Segmentation
99
from valor_lite.semantic_segmentation.computation import (
1010
compute_intermediate_confusion_matrices,
@@ -426,7 +426,7 @@ def finalize(self) -> Evaluator:
426426
"""
427427

428428
if len(self.matrices) == 0:
429-
raise EmptyCacheError()
429+
raise EmptyEvaluatorError()
430430

431431
n_labels = len(self._evaluator.index_to_label)
432432
n_datums = len(self._evaluator.index_to_datum_id)

tests/classification/test_accuracy.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ def test_accuracy_basic(basic_classifications: list[Classification]):
6767
loader.add_data(basic_classifications)
6868
evaluator = loader.finalize()
6969

70+
assert evaluator.ignored_prediction_labels == ["1", "2"]
71+
assert evaluator.missing_prediction_labels == []
7072
assert evaluator.metadata.to_dict() == {
7173
"number_of_datums": 3,
7274
"number_of_ground_truths": 3,
@@ -162,6 +164,8 @@ def test_accuracy_with_image_example(
162164
loader.add_data(classifications_image_example)
163165
evaluator = loader.finalize()
164166

167+
assert evaluator.ignored_prediction_labels == ["v1", "v8", "v5"]
168+
assert evaluator.missing_prediction_labels == []
165169
assert evaluator.metadata.to_dict() == {
166170
"number_of_datums": 2,
167171
"number_of_ground_truths": 2,
@@ -195,6 +199,8 @@ def test_accuracy_with_tabular_example(
195199
loader.add_data(classifications_tabular_example)
196200
evaluator = loader.finalize()
197201

202+
assert evaluator.ignored_prediction_labels == []
203+
assert evaluator.missing_prediction_labels == []
198204
assert evaluator.metadata.to_dict() == {
199205
"number_of_datums": 10,
200206
"number_of_ground_truths": 10,

tests/classification/test_dataloader.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import pytest
22

33
from valor_lite.classification import Classification, DataLoader
4-
from valor_lite.exceptions import EmptyCacheError
4+
from valor_lite.exceptions import EmptyEvaluatorError
55

66

77
def test_finalization_no_data():
88
loader = DataLoader()
9-
with pytest.raises(EmptyCacheError):
9+
with pytest.raises(EmptyEvaluatorError):
1010
loader.finalize()
1111

1212

tests/semantic_segmentation/test_dataloader.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import pytest
22

3-
from valor_lite.exceptions import EmptyCacheError
3+
from valor_lite.exceptions import EmptyEvaluatorError
44
from valor_lite.semantic_segmentation import DataLoader, Segmentation
55

66

77
def test_no_data():
88
loader = DataLoader()
9-
with pytest.raises(EmptyCacheError):
9+
with pytest.raises(EmptyEvaluatorError):
1010
loader.finalize()
1111

1212

tests/semantic_segmentation/test_evaluator.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ def test_label_mismatch():
113113
]
114114
)
115115
evaluator = loader.finalize()
116+
print(evaluator._confusion_matrices)
116117
assert np.all(
117118
evaluator._confusion_matrices
118119
== np.array(
@@ -171,6 +172,7 @@ def test_empty_groundtruths():
171172
]
172173
)
173174
evaluator = loader.finalize()
175+
print(evaluator._confusion_matrices)
174176
assert np.all(
175177
evaluator._confusion_matrices
176178
== np.array(
@@ -227,6 +229,7 @@ def test_empty_predictions():
227229
]
228230
)
229231
evaluator = loader.finalize()
232+
print(evaluator._confusion_matrices)
230233
assert np.all(
231234
evaluator._confusion_matrices
232235
== np.array(

0 commit comments

Comments
 (0)