remove suppression of counts, pr curves (#852)

Author: czaloom

.github/CODEOWNERS

@@ -1 +1 @@
-*       @czaloom @ekorman @jyono @rsbowman-striveworks
+* @Striveworks/models

.gitignore

@@ -28,4 +28,5 @@ site/*
 *.jpeg
 *.pt
 *.png
-*.jpg
+*.jpg
+*.parquet

src/valor_lite/object_detection/manager.py

@@ -410,7 +410,6 @@ def compute_precision_recall(
         )
         return unpack_precision_recall_into_metric_lists(
             results=results,
-            label_metadata=label_metadata,
             iou_thresholds=iou_thresholds,
             score_thresholds=score_thresholds,
             index_to_label=self.index_to_label,

src/valor_lite/object_detection/utilities.py

@@ -23,7 +23,6 @@ def unpack_precision_recall_into_metric_lists(
     iou_thresholds: list[float],
     score_thresholds: list[float],
     index_to_label: list[str],
-    label_metadata: NDArray[np.int32],
 ):
     (
         (
@@ -125,13 +124,9 @@ def unpack_precision_recall_into_metric_lists(
         )
         for iou_idx, iou_threshold in enumerate(iou_thresholds)
         for label_idx, label in enumerate(index_to_label)
-        if label_metadata[label_idx, 0] > 0
     ]
 
     for label_idx, label in enumerate(index_to_label):
-        if label_metadata[label_idx, 0] == 0:
-            continue
-
         for score_idx, score_threshold in enumerate(score_thresholds):
             for iou_idx, iou_threshold in enumerate(iou_thresholds):
 

tests/object_detection/test_counts.py

@@ -592,6 +592,24 @@ def test_counts_ranked_pair_ordering(
                     "label": "label3",
                 },
             },
+            {
+                "type": "Counts",
+                "value": {"tp": 0, "fp": 1, "fn": 0},
+                "parameters": {
+                    "iou_threshold": 0.5,
+                    "score_threshold": 0.0,
+                    "label": "label4",
+                },
+            },
+            {
+                "type": "Counts",
+                "value": {"tp": 0, "fp": 1, "fn": 0},
+                "parameters": {
+                    "iou_threshold": 0.75,
+                    "score_threshold": 0.0,
+                    "label": "label4",
+                },
+            },
         ]
         for m in actual_metrics:
             assert m in expected_metrics

tests/object_detection/test_pr_curve.py

@@ -151,6 +151,28 @@ def test_pr_curve_using_torch_metrics_example(
                 "label": "2",
             },
         },
+        {
+            "type": "PrecisionRecallCurve",
+            "value": {
+                "precisions": [0.0 for _ in range(101)],
+                "scores": [0.318] + [0.0 for _ in range(100)],
+            },
+            "parameters": {
+                "iou_threshold": 0.5,
+                "label": "3",
+            },
+        },
+        {
+            "type": "PrecisionRecallCurve",
+            "value": {
+                "precisions": [0.0 for _ in range(101)],
+                "scores": [0.318] + [0.0 for _ in range(100)],
+            },
+            "parameters": {
+                "iou_threshold": 0.75,
+                "label": "3",
+            },
+        },
         {
             "type": "PrecisionRecallCurve",
             "value": {