add back filter post init validator

Author: czaloom

src/valor_lite/object_detection/manager.py

@@ -99,6 +99,21 @@ class Filter:
     mask_predictions: NDArray[np.bool_]
     metadata: Metadata
 
+    def __post_init__(self):
+        # validate datums mask
+        if not self.mask_datums.any():
+            raise EmptyFilterError("filter removes all datums")
+
+        # validate annotation masks
+        no_gts = self.mask_groundtruths.all()
+        no_pds = self.mask_predictions.all()
+        if no_gts and no_pds:
+            raise EmptyFilterError("filter removes all annotations")
+        elif no_gts:
+            warnings.warn("filter removes all ground truths")
+        elif no_pds:
+            warnings.warn("filter removes all predictions")
+
 
 class Evaluator:
     """

src/valor_lite/semantic_segmentation/manager.py

@@ -71,6 +71,15 @@ class Filter:
     label_mask: NDArray[np.bool_]
     metadata: Metadata
 
+    def __post_init__(self):
+        # validate datum mask
+        if not self.datum_mask.any():
+            raise EmptyFilterError("filter removes all datums")
+
+        # validate label mask
+        if self.label_mask.all():
+            raise EmptyFilterError("filter removes all labels")
+
 
 class Evaluator:
     """

tests/classification/test_filtering.py

@@ -4,7 +4,13 @@
 import numpy as np
 import pytest
 
-from valor_lite.classification import Classification, DataLoader, MetricType
+from valor_lite.classification import (
+    Classification,
+    DataLoader,
+    Filter,
+    Metadata,
+    MetricType,
+)
 from valor_lite.exceptions import EmptyFilterError
 
 
@@ -890,3 +896,23 @@ def test_filtering_six_classifications_by_indices(
         assert m in expected_metrics
     for m in expected_metrics:
         assert m in actual_metrics
+
+
+def test_filter_object():
+
+    # check that no datums are defined
+    with pytest.raises(EmptyFilterError) as e:
+        Filter(
+            datum_mask=np.array([False, False, False]),
+            valid_label_indices=np.array([0, 1, 2]),
+            metadata=Metadata(),
+        )
+    assert "filter removes all datums" in str(e)
+
+    # check that no labels are defined
+    with pytest.raises(EmptyFilterError) as e:
+        Filter(
+            datum_mask=np.array([True, False, False]),
+            valid_label_indices=np.array([]),
+            metadata=Metadata(),
+        )

tests/object_detection/test_filtering.py

@@ -9,6 +9,8 @@
     BoundingBox,
     DataLoader,
     Detection,
+    Filter,
+    Metadata,
     MetricType,
 )
 
@@ -780,3 +782,47 @@ def test_filtering_invalid_indices(
     with pytest.raises(ValueError) as e:
         evaluator.create_filter(labels=np.array([1000]))
     assert "cannot exceed total number of labels" in str(e)
+
+
+def test_filter_object():
+
+    mask = np.array([True, False, False])
+    true_mask = np.array([True, True, True])
+    false_mask = ~true_mask
+
+    # check that no datums are defined
+    with pytest.raises(EmptyFilterError) as e:
+        Filter(
+            mask_datums=false_mask,
+            mask_groundtruths=mask,
+            mask_predictions=mask,
+            metadata=Metadata(),
+        )
+    assert "filter removes all datums" in str(e)
+
+    # check that no annotations are defined
+    with pytest.raises(EmptyFilterError) as e:
+        Filter(
+            mask_datums=mask,
+            mask_groundtruths=true_mask,
+            mask_predictions=true_mask,
+            metadata=Metadata(),
+        )
+
+    # check that no ground truths are defined
+    with pytest.warns(UserWarning):
+        Filter(
+            mask_datums=mask,
+            mask_groundtruths=true_mask,
+            mask_predictions=mask,
+            metadata=Metadata(),
+        )
+
+    # check that no predictions are defined
+    with pytest.warns(UserWarning):
+        Filter(
+            mask_datums=mask,
+            mask_groundtruths=mask,
+            mask_predictions=true_mask,
+            metadata=Metadata(),
+        )

tests/semantic_segmentation/test_filtering.py

@@ -2,7 +2,12 @@
 import pytest
 
 from valor_lite.exceptions import EmptyFilterError
-from valor_lite.semantic_segmentation import DataLoader, Segmentation
+from valor_lite.semantic_segmentation import (
+    DataLoader,
+    Filter,
+    Metadata,
+    Segmentation,
+)
 
 
 def test_filtering(segmentations_from_boxes: list[Segmentation]):
@@ -182,3 +187,23 @@ def test_filtering_invalid_indices(
     with pytest.raises(ValueError) as e:
         evaluator.create_filter(labels=np.array([1000]))
     assert "cannot exceed total number of labels" in str(e)
+
+
+def test_filter_object():
+
+    mask = np.array([True, False, False])
+    true_mask = np.array([True, True, True])
+    false_mask = ~true_mask
+
+    # check that no datums are defined
+    with pytest.raises(EmptyFilterError) as e:
+        Filter(datum_mask=false_mask, label_mask=mask, metadata=Metadata())
+    assert "filter removes all datums" in str(e)
+
+    # check that no labels are defined
+    with pytest.raises(EmptyFilterError) as e:
+        Filter(
+            datum_mask=mask,
+            label_mask=true_mask,
+            metadata=Metadata(),
+        )