Update ESLint, CI

Author: alessiostalla

.eslintignore

@@ -9,7 +9,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, 20.x]
+        node-version: [20.x, 22.x]
 
     steps:
       - uses: actions/checkout@v4

.eslintrc.js

@@ -121,29 +121,32 @@
 		"publish-lib": "yarn dist && yarn publish --access public && yarn --use-yarnrc .yarnrc-github-packages publish"
 	},
 	"devDependencies": {
+		"@eslint/eslintrc": "^3.2.0",
+		"@eslint/js": "^9.20.0",
 		"@lionweb/core": "^0.6.7",
 		"@lionweb/utilities": "^0.6.7",
 		"@tsconfig/recommended": "^1.0.3",
 		"@types/chai": "^4.3.11",
 		"@types/ecore": "^0.12.5",
 		"@types/jest": "^29.5.10",
 		"@types/node": "^18.19.2",
-		"@typescript-eslint/eslint-plugin": "^6.13.2",
-		"@typescript-eslint/parser": "^6.13.2",
-		"antlr4ng": "^3.0.4",
+		"@typescript-eslint/eslint-plugin": "^8.24.0",
+		"@typescript-eslint/parser": "^8.24.0",
+		"antlr4ng": "^3.0.14",
 		"antlr4ng-cli": "^2.0.0",
 		"chai": "^4.3.10",
 		"cmd-ts": "^0.13.0",
 		"cross-env": "^7.0.3",
 		"ecore": "^0.12.0",
-		"eslint": "^8.55.0",
-		"i18next": "^23.11.5",
+		"eslint": "^9.20.1",
+		"i18next": "^24.2.2",
 		"jest": "^29.7.0",
 		"merge-options": "^2.0.0",
 		"rimraf": "^3.0.0",
 		"ts-jest": "^29.1.1",
 		"ts-node": "^10.9.1",
 		"typedoc": "^0.25.7",
-		"typescript": "^5.3.2"
+		"typescript": "^5.3.2",
+		"typescript-eslint": "^8.24.0"
 	}
 }

.github/workflows/node.js.yml

@@ -499,7 +499,6 @@ export function generateASTClasses(model: ECore.EPackage): PackageDescription {
     return pkg;
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export function loadEPackages(data: any, resource: ECore.Resource): ECore.EPackage[] {
     if(typeof data === "string") {
         data = JSON.parse(data);
@@ -565,7 +564,7 @@ class ReferencesTracker {
         let eClass;
         try {
             eClass = findEClass(uri, this.resource);
-        } catch (e) {
+        } catch {
             //Not an eclass
         }
         if (eClass) {
@@ -735,7 +734,6 @@ function setChild(
  * @param strict if true (the default), unknown attributes are an error, otherwise they're ignored.
  * @param referencesTracker references tracker used to read references and solve them later (after loading all nodes)
  */
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 function importJsonObject(
     obj: any, resource: ECore.Resource, eClass?: ECore.EClass,
     strict = true, referencesTracker: ReferencesTracker = new ReferencesTracker(resource)): ECore.EObject {

package.json

@@ -198,7 +198,6 @@ export class LionwebNode extends NodeAdapter {
         super();
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     get(...path: string[]): LionwebNode | undefined {
         let result: LionwebNode | undefined = undefined;
         // eslint-disable-next-line @typescript-eslint/no-this-alias

src/interop/ecore.ts

@@ -55,7 +55,7 @@ export function getNodeDefinition(node: Node | (abstract new (...args: any[]) =>
             let metadataHolder;
             try {
                 metadataHolder = new (node as any)();
-            } catch (_) {
+            } catch {
                 metadataHolder = node;
             }
             for(const p in definition.features) {
@@ -69,7 +69,7 @@ export function getNodeDefinition(node: Node | (abstract new (...args: any[]) =>
                 }
             }
             definition.resolved = true;
-        } catch (e) {
+        } catch {
             //Ignore
         }
     }
@@ -116,7 +116,7 @@ export class SimpleOrigin extends Origin {
     }
 }
 
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 export interface Destination {}
 
 

src/interop/lionweb.ts

@@ -330,7 +330,7 @@ export class ASTTransformer {
 
         try {
             childNodeFactory.set(node, child);
-        } catch (e) {
+        } catch {
             throw new Error(`Could not set child ${childNodeFactory}`);
         }
     }

src/model/model.ts

@@ -33,7 +33,7 @@ describe('Issues', function() {
 
     it("has capitalized messages",
         function () {
-            let issue = Issue.syntactic("unexpected token: foo", IssueSeverity.ERROR, undefined, undefined, SYNTAX_ERROR);
+            const issue = Issue.syntactic("unexpected token: foo", IssueSeverity.ERROR, undefined, undefined, SYNTAX_ERROR);
             expect(issue.message).to.equal("Unexpected token: foo");
         });
 });

src/transformation/transformation.ts

@@ -96,6 +96,7 @@ describe('JSON generator', function() {
         });
     it("Wrongly configured node",
         function () {
+            // eslint-disable-next-line @typescript-eslint/no-require-imports
             expect(() => require("./wrong-node")).to.throw;
         });
     it("Node with resolved reference by name",