Correctly urlencode path in setcookie(); fix #3538

ctrlaltca · ctrlaltca · commit 66485d8c035e · 2026-01-12T22:42:09.000+01:00
Some characters are valid in URLs but not in cookies, eg. comma or semicolon.
They needs to be encoded properly.
diff --git a/php/elFinder.class.php b/php/elFinder.class.php
@@ -2087,7 +2087,7 @@ protected function file($args)
         }
 
         if ($args['cpath'] && $args['reqid']) {
-            setcookie('elfdl' . $args['reqid'], '1', 0, $args['cpath']);
+            setcookie('elfdl' . $args['reqid'], '1', 0, urlencode($args['cpath']));
         }
 
         $result = array(

Original file line number	Diff line number	Diff line change
`@@ -2087,7 +2087,7 @@ protected function file($args)`
`2087`	`2087`	`}`
`2088`	`2088`
`2089`	`2089`	`if ($args['cpath'] && $args['reqid']) {`
`2090`		`- setcookie('elfdl' . $args['reqid'], '1', 0, $args['cpath']);`
	`2090`	`+ setcookie('elfdl' . $args['reqid'], '1', 0, urlencode($args['cpath']));`
`2091`	`2091`	`}`
`2092`	`2092`
`2093`	`2093`	`$result = array(`