Skip to content

Commit 122dbd9

Browse files
committed
Generate cmake error when BUILD_NUMBER is empty
1 parent a0c7666 commit 122dbd9

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

src/robomongo/CMakeLists.txt

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -176,17 +176,21 @@ find_package(Git)
176176
if(GIT_FOUND)
177177
MESSAGE( STATUS "Info: Git found" )
178178
execute_process(
179-
COMMAND ${GIT_EXECUTABLE} rev-parse --short head
179+
COMMAND ${GIT_EXECUTABLE} rev-parse --short HEAD
180180
WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
181-
OUTPUT_VARIABLE "BUILD_NUMBER"
182-
ERROR_QUIET
181+
OUTPUT_VARIABLE "BUILD_NUMBER"
183182
OUTPUT_STRIP_TRAILING_WHITESPACE
184-
)
185-
else(git_found)
186-
MESSAGE( STATUS "Error: Unable to find Git" )
183+
)
184+
else(GIT_FOUND)
185+
MESSAGE( FATAL_ERROR "Unable to find Git" )
187186
set(BUILD_NUMBER 0)
188187
endif(GIT_FOUND)
189-
MESSAGE( STATUS "Info: BUILD_NUMBER set as ${BUILD_NUMBER}" )
188+
189+
if(BUILD_NUMBER STREQUAL "")
190+
MESSAGE( FATAL_ERROR "Failed to get BUILD_NUMBER" )
191+
endif()
192+
193+
MESSAGE( STATUS "Info: BUILD_NUMBER set as " \"${BUILD_NUMBER}\" )
190194
191195
target_compile_definitions(robomongo
192196
PRIVATE

0 commit comments

Comments
 (0)