[MIG] purchase_allowed_product: Migration to 18.0

Author: apami0111

purchase_allowed_product/README.rst

@@ -1,3 +1,7 @@
+.. image:: https://odoo-community.org/readme-banner-image
+   :target: https://odoo-community.org/get-involved?utm_source=readme
+   :alt: Odoo Community Association
+
 ====================================
 Purchase and Invoice Allowed Product
 ====================================
@@ -7,23 +11,23 @@ Purchase and Invoice Allowed Product
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:376569ec84ca307bb83baf306b91200c633f7ee20fd6f9feb448155fb174beef
+   !! source digest: sha256:eb1b9dbaa74e94be393c30f67b80add2d636d716a513727c65216e10fe1b6cc1
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
     :target: https://odoo-community.org/page/development-status
     :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpurchase--workflow-lightgray.png?logo=github
-    :target: https://github.com/OCA/purchase-workflow/tree/17.0/purchase_allowed_product
+    :target: https://github.com/OCA/purchase-workflow/tree/18.0/purchase_allowed_product
     :alt: OCA/purchase-workflow
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_allowed_product
+    :target: https://translation.odoo-community.org/projects/purchase-workflow-18-0/purchase-workflow-18-0-purchase_allowed_product
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&target_branch=17.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -48,7 +52,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/purchase-workflow/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_allowed_product%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_allowed_product%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -76,6 +80,7 @@ Contributors
   - Darius Žižys
 
 - Eduardo de Miguel (`Moduon <https://www.moduon.team/>`__)
+- Alejandro Parrales <alejandro17parrales@gmail.com>
 
 Maintainers
 -----------
@@ -90,6 +95,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/purchase-workflow <https://github.com/OCA/purchase-workflow/tree/17.0/purchase_allowed_product>`_ project on GitHub.
+This module is part of the `OCA/purchase-workflow <https://github.com/OCA/purchase-workflow/tree/18.0/purchase_allowed_product>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

purchase_allowed_product/__manifest__.py

@@ -6,12 +6,15 @@
     "name": "Purchase and Invoice Allowed Product",
     "summary": "This module allows to select only products that can be "
     "supplied by the vendor",
-    "version": "17.0.1.0.0",
+    "version": "18.0.1.0.0",
     "category": "Accounting & Finance",
     "website": "https://github.com/OCA/purchase-workflow",
     "author": "Akretion, Odoo Community Association (OCA)",
     "license": "AGPL-3",
-    "depends": ["purchase", "base_view_inheritance_extension"],
+    "depends": [
+        "purchase",
+        "base_view_inheritance_extension",
+    ],
     "data": [
         "views/res_partner_views.xml",
         "views/account_move_views.xml",

purchase_allowed_product/i18n/purchase_allowed_product.pot

@@ -4,7 +4,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: Odoo Server 17.0\n"
+"Project-Id-Version: Odoo Server 18.0\n"
 "Report-Msgid-Bugs-To: \n"
 "Last-Translator: \n"
 "Language-Team: \n"
@@ -30,7 +30,6 @@ msgstr ""
 #. module: purchase_allowed_product
 #: model:ir.model.fields,help:purchase_allowed_product.field_account_bank_statement_line__use_only_supplied_product
 #: model:ir.model.fields,help:purchase_allowed_product.field_account_move__use_only_supplied_product
-#: model:ir.model.fields,help:purchase_allowed_product.field_account_payment__use_only_supplied_product
 #: model:ir.model.fields,help:purchase_allowed_product.field_purchase_order__use_only_supplied_product
 #: model:ir.model.fields,help:purchase_allowed_product.field_supplied_product_mixin__use_only_supplied_product
 msgid "If checked, only the products provided by this supplier will be shown."
@@ -70,7 +69,6 @@ msgstr ""
 #. module: purchase_allowed_product
 #: model:ir.model.fields,field_description:purchase_allowed_product.field_account_bank_statement_line__use_only_supplied_product
 #: model:ir.model.fields,field_description:purchase_allowed_product.field_account_move__use_only_supplied_product
-#: model:ir.model.fields,field_description:purchase_allowed_product.field_account_payment__use_only_supplied_product
 #: model:ir.model.fields,field_description:purchase_allowed_product.field_purchase_order__use_only_supplied_product
 #: model:ir.model.fields,field_description:purchase_allowed_product.field_supplied_product_mixin__use_only_supplied_product
 msgid "Use only allowed products"

purchase_allowed_product/models/product.py

@@ -16,7 +16,6 @@ def _search(
         offset=0,
         limit=None,
         order=None,
-        access_rights_uid=None,
     ):
         if self.env.context.get("use_only_supplied_product"):
             restrict_supplier_id = self.env.context.get("restrict_supplier_id")
@@ -38,5 +37,4 @@ def _search(
             offset=offset,
             limit=limit,
             order=order,
-            access_rights_uid=access_rights_uid,
         )

purchase_allowed_product/readme/CONTRIBUTORS.md

@@ -7,3 +7,4 @@
 - [Via laurea](https://www.vialaurea.com):
   - Darius Žižys
 - Eduardo de Miguel ([Moduon](https://www.moduon.team/))
+- Alejandro Parrales \<<alejandro17parrales@gmail.com>\>

purchase_allowed_product/static/description/index.html

@@ -3,7 +3,7 @@
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
-<title>Purchase and Invoice Allowed Product</title>
+<title>README.rst</title>
 <style type="text/css">
 
 /*
@@ -360,16 +360,21 @@
 </style>
 </head>
 <body>
-<div class="document" id="purchase-and-invoice-allowed-product">
-<h1 class="title">Purchase and Invoice Allowed Product</h1>
+<div class="document">
 
+
+<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
+<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
+</a>
+<div class="section" id="purchase-and-invoice-allowed-product">
+<h1>Purchase and Invoice Allowed Product</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:376569ec84ca307bb83baf306b91200c633f7ee20fd6f9feb448155fb174beef
+!! source digest: sha256:eb1b9dbaa74e94be393c30f67b80add2d636d716a513727c65216e10fe1b6cc1
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/purchase-workflow/tree/17.0/purchase_allowed_product"><img alt="OCA/purchase-workflow" src="https://img.shields.io/badge/github-OCA%2Fpurchase--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_allowed_product"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/purchase-workflow/tree/18.0/purchase_allowed_product"><img alt="OCA/purchase-workflow" src="https://img.shields.io/badge/github-OCA%2Fpurchase--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/purchase-workflow-18-0/purchase-workflow-18-0-purchase_allowed_product"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module adds a restriction in purchase and supplier invoices that
 has the mark “Order and invoice only supplied products” checked for
 allowing to select only products that can be supplied by the defined
@@ -390,23 +395,23 @@ <h1 class="title">Purchase and Invoice Allowed Product</h1>
 </ul>
 </div>
 <div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#toc-entry-1">Bug Tracker</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-1">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/purchase-workflow/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_allowed_product%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_allowed_product%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h1><a class="toc-backref" href="#toc-entry-2">Credits</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-2">Credits</a></h2>
 <div class="section" id="authors">
-<h2><a class="toc-backref" href="#toc-entry-3">Authors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-3">Authors</a></h3>
 <ul class="simple">
 <li>Akretion</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h2><a class="toc-backref" href="#toc-entry-4">Contributors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-4">Contributors</a></h3>
 <ul class="simple">
 <li>Chafique Delli &lt;<a class="reference external" href="mailto:chafique.delli&#64;akretion.com">chafique.delli&#64;akretion.com</a>&gt;</li>
 <li>Mourad EL HADJ MIMOUNE &lt;<a class="reference external" href="mailto:mourad.elhadj.mimoune&#64;akretion.com">mourad.elhadj.mimoune&#64;akretion.com</a>&gt;</li>
@@ -421,21 +426,23 @@ <h2><a class="toc-backref" href="#toc-entry-4">Contributors</a></h2>
 </ul>
 </li>
 <li>Eduardo de Miguel (<a class="reference external" href="https://www.moduon.team/">Moduon</a>)</li>
+<li>Alejandro Parrales &lt;<a class="reference external" href="mailto:alejandro17parrales&#64;gmail.com">alejandro17parrales&#64;gmail.com</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#toc-entry-5">Maintainers</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-5">Maintainers</a></h3>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org">
 <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
 </a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/purchase-workflow/tree/17.0/purchase_allowed_product">OCA/purchase-workflow</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/purchase-workflow/tree/18.0/purchase_allowed_product">OCA/purchase-workflow</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
 </div>
+</div>
 </body>
 </html>

purchase_allowed_product/tests/test_purchase_allowed_product.py

@@ -3,40 +3,43 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 
-from odoo.tests.common import Form, TransactionCase
+from odoo.tests import Form
 
+from odoo.addons.base.tests.common import BaseCommon
 
-class TestPurchaseAllowedProduct(TransactionCase):
-    def setUp(self):
-        super().setUp()
-        self.supplierinfo_model = self.env["product.supplierinfo"]
-        self.product_model = self.env["product.product"]
-        self.partner_4 = self.env.ref("base.res_partner_4")
-        self.supplierinfo = self.supplierinfo_model.search(
-            [("partner_id", "=", self.partner_4.id)]
+
+class TestPurchaseAllowedProduct(BaseCommon):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.supplierinfo_model = cls.env["product.supplierinfo"]
+        cls.product_model = cls.env["product.product"]
+        cls.partner = cls.env["res.partner"].create({"name": "Test supplier"})
+        cls.supplierinfo = cls.supplierinfo_model.search(
+            [("partner_id", "=", cls.partner.id)]
         )
-        self.partner_4_supplied_products = self.product_model.search(
+        cls.partner_supplied_products = cls.product_model.search(
             [
                 (
                     "product_tmpl_id",
                     "in",
-                    [x.product_tmpl_id.id for x in self.supplierinfo],
+                    [x.product_tmpl_id.id for x in cls.supplierinfo],
                 )
             ]
         )
 
     def test_purchase_onchange(self):
         """A user creates a purchase from the form."""
-        self.partner_4.use_only_supplied_product = True
+        self.partner.use_only_supplied_product = True
         with Form(
             self.env["purchase.order"], view="purchase.purchase_order_form"
         ) as purchase_form:
-            purchase_form.partner_id = self.partner_4
+            purchase_form.partner_id = self.partner
 
             # Ensure the use_only_supplied_product is set
             self.assertEqual(
                 purchase_form.use_only_supplied_product,
-                self.partner_4.use_only_supplied_product,
+                self.partner.use_only_supplied_product,
             )
 
             self.assertEqual(purchase_form.use_only_supplied_product, True)
@@ -45,23 +48,21 @@ def test_purchase_onchange(self):
                 "use_only_supplied_product": purchase_form.use_only_supplied_product,
             }
         supplied_product = self.product_model.with_context(**context)._search([])
-        self.assertEqual(
-            set(supplied_product), set(self.partner_4_supplied_products.ids)
-        )
+        self.assertEqual(set(supplied_product), set(self.partner_supplied_products.ids))
 
     def test_invoice_onchange(self):
         """A user creates a invoice from the form."""
-        self.partner_4.use_only_supplied_product = True
+        self.partner.use_only_supplied_product = True
         with Form(
             self.env["account.move"].with_context(default_move_type="out_invoice"),
             view="account.view_move_form",
         ) as invoice_form:
-            invoice_form.partner_id = self.partner_4
+            invoice_form.partner_id = self.partner
 
             # Ensure the use_only_supplied_product is set
             self.assertEqual(
                 invoice_form.use_only_supplied_product,
-                self.partner_4.use_only_supplied_product,
+                self.partner.use_only_supplied_product,
             )
 
             self.assertEqual(invoice_form.use_only_supplied_product, True)
@@ -70,6 +71,4 @@ def test_invoice_onchange(self):
                 "use_only_supplied_product": invoice_form.use_only_supplied_product,
             }
         supplied_product = self.product_model.with_context(**context)._search([])
-        self.assertEqual(
-            set(supplied_product), set(self.partner_4_supplied_products.ids)
-        )
+        self.assertEqual(set(supplied_product), set(self.partner_supplied_products.ids))

purchase_allowed_product/views/account_move_views.xml

@@ -4,15 +4,15 @@
         <field name="model">account.move</field>
         <field name="inherit_id" ref="account.view_move_form" />
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='partner_id']/.." position="inside">
+            <xpath expr="//group[@id='header_left_group']" position="inside">
                 <field
-                    invisible="state != 'draft' or move_type not in ('in_invoice', 'in_refund', 'in_receipt')"
                     name="use_only_supplied_product"
+                    invisible="state != 'draft' or move_type not in ('in_invoice', 'in_refund', 'in_receipt')"
                     widget="boolean_toggle"
                 />
             </xpath>
             <xpath
-                expr="//field[@name='invoice_line_ids']/tree/field[@name='product_id']"
+                expr="//field[@name='invoice_line_ids']/list/field[@name='product_id']"
                 position="attributes"
             >
                 <attribute name="context">

purchase_allowed_product/views/purchase_order_views.xml

@@ -8,7 +8,7 @@
                 <field name="use_only_supplied_product" widget="boolean_toggle" />
             </xpath>
             <xpath
-                expr="//field[@name='order_line']/tree/field[@name='product_id']"
+                expr="//field[@name='order_line']/list/field[@name='product_id']"
                 position="attributes"
             >
                 <attribute name="context" operation="update">