Skip to content

Commit 9c98a78

Browse files
committed
Fix crash when file does not contain header text
Fixes StyleCop/StyleCop#78
1 parent 72e3251 commit 9c98a78

3 files changed

Lines changed: 11 additions & 4 deletions

File tree

install/StyleCop.nuspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,13 @@
33
<metadata>
44
<id>StyleCop.StyleCop</id>
55
<title>StyleCop by JetBrains</title>
6-
<version>2016.3.0</version>
6+
<version>2016.3.1</version>
77
<authors>Matt Ellis, Andy Reeves</authors>
88
<owners>JetBrains, Matt Ellis</owners>
99
<summary>StyleCop analyzes C# source code to enforce a set of style and consistency rules. Maintained by JetBrains</summary>
1010
<description>StyleCop analyzes C# source code to enforce a set of style and consistency rules. This plugin is compatible with StyleCop 4.7.54, and maintained by JetBrains.</description>
1111
<releaseNotes>
12+
&#8226; Fix crash if the file doesn't have a header (StyleCop/StyleCop#78)
1213
&#8226; Updated to ReSharper 2016.3
1314

1415
From 2016.2.1:

src/StyleCop.ReSharper/Core/Utils.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -662,7 +662,13 @@ public static ITreeNode GetElementAtCaret(ISolution solution, ITextControl textC
662662
/// </returns>
663663
public static string GetFileHeader(ICSharpFile file)
664664
{
665-
return GetFileHeaderTreeRange(file).GetDocumentRange().GetText();
665+
var documentRange = GetFileHeaderTreeRange(file).GetDocumentRange();
666+
if (!documentRange.IsValid())
667+
{
668+
return string.Empty;
669+
}
670+
671+
return documentRange.GetText();
666672
}
667673

668674
/// <summary>

src/StyleCop.ReSharper/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
using System.Runtime.InteropServices;
2222
using JetBrains.ReSharper.Feature.Services.Daemon;
2323

24-
[assembly: AssemblyTitle("StyleCop R# 8.0.0 Plugin")]
25-
[assembly: AssemblyDescription("R# plugin for StyleCop")]
24+
[assembly: AssemblyTitle("StyleCop for ReSharper")]
25+
[assembly: AssemblyDescription("StyleCop for ReSharper")]
2626
[assembly: AssemblyConfiguration("")]
2727
[assembly: AssemblyCompany("")]
2828
[assembly: AssemblyProduct(StyleCop.Constants.ProductName)]

0 commit comments

Comments
 (0)