Merge pull request #267 from leocagli/test/required-fixture-groups

test(fixtures): fail when a required fixture group is missing

Author: karagozemin

scripts/check-fixture-sizes.mjs

@@ -1,5 +1,5 @@
 // Copyright (c) 2026 Sub Rosa contributors
-import { readdirSync, statSync } from "node:fs";
+import { existsSync, readdirSync, statSync } from "node:fs";
 import { join, relative } from "node:path";
 
 const GROUPS = [
@@ -37,8 +37,11 @@ function walk(dir, include) {
         files.push(full);
       }
     }
-  } catch {
-    // directory does not exist
+  } catch (error) {
+    // Un directorio ausente es normal al recorrer en profundidad. Cualquier
+    // otro error, como un permiso denegado, no lo es: tragarselo hacia que un
+    // grupo ilegible se viera igual que uno vacio.
+    if (error.code !== "ENOENT" && error.code !== "ENOTDIR") throw error;
   }
   return files;
 }
@@ -59,7 +62,15 @@ function checkGroup(group) {
   const totalOk = totalBytes <= group.totalBytes;
   const allFilesOk = files.every((f) => f.ok);
 
-  return { label: group.label, files, totalBytes, totalOk, ok: allFilesOk && totalOk };
+  return {
+    label: group.label,
+    dir: group.dir,
+    dirExists: existsSync(group.dir),
+    files,
+    totalBytes,
+    totalOk,
+    ok: allFilesOk && totalOk,
+  };
 }
 
 function main() {
@@ -68,8 +79,25 @@ function main() {
   for (const group of GROUPS) {
     const result = checkGroup(group);
 
+    // Todo grupo configurado en GROUPS es obligatorio. Antes un grupo ausente
+    // o vacio salia por SKIP y el proceso terminaba en 0, asi que borrar un
+    // grupo entero desactivaba en silencio el presupuesto que lo cuidaba.
+    //
+    // Los dos casos se informan por separado a proposito: "no existe" y "esta
+    // vacio" se arreglan distinto, y un solo mensaje para los dos te obliga a
+    // ir a mirar cual de los dos fue.
+    if (!result.dirExists) {
+      console.log(`  [FAIL] ${group.label} — required fixture directory is missing: ${group.dir}`);
+      allPassed = false;
+      continue;
+    }
+
     if (result.files.length === 0) {
-      console.log(`  [SKIP] ${group.label} — directory not found or empty`);
+      console.log(
+        `  [FAIL] ${group.label} — required fixture directory has no matching files: ` +
+          `${group.dir} (expected files matching ${group.include})`,
+      );
+      allPassed = false;
       continue;
     }
 
@@ -102,7 +130,7 @@ function main() {
     console.log("All fixture size budgets are within limits.");
     process.exit(0);
   } else {
-    console.log("Some fixture size budgets are exceeded.");
+    console.log("Fixture check failed: a budget was exceeded or a required group is missing.");
     console.log("To update budgets, edit GROUPS in scripts/check-fixture-sizes.mjs.");
     process.exit(1);
   }

scripts/check-fixture-sizes.test.mjs

@@ -1,26 +1,108 @@
 // Copyright (c) 2026 Sub Rosa contributors
 import { execFileSync } from "node:child_process";
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
 import { describe, it } from "node:test";
 import assert from "node:assert/strict";
 
+const CHECKER = new URL("check-fixture-sizes.mjs", import.meta.url).pathname;
+const RAIZ = new URL("..", import.meta.url).pathname;
+
+/** Corre el checker y devuelve salida y codigo, sin tirar cuando falla. */
+function correr(cwd) {
+  try {
+    const stdout = execFileSync("node", [CHECKER], { encoding: "utf-8", cwd });
+    return { code: 0, stdout };
+  } catch (error) {
+    return { code: error.status, stdout: error.stdout ?? "" };
+  }
+}
+
+/**
+ * Un proyecto de mentira con los tres grupos que declara GROUPS.
+ *
+ * `omitir` no crea ese directorio; `vaciar` lo crea sin archivos que matcheen.
+ * Son los dos casos que antes salian por SKIP con exit 0.
+ */
+function proyecto({ omitir = null, vaciar = null } = {}) {
+  const raiz = mkdtempSync(join(tmpdir(), "fixture-check-"));
+  const grupos = [
+    ["services/receipt-cli/src/fixtures", "a.json", "{}"],
+    ["contracts/round/test_snapshots/test", "b.json", "{}"],
+    ["apps/web/src/demo", "c.ts", "export const x = 1;\n"],
+  ];
+  for (const [dir, archivo, contenido] of grupos) {
+    if (dir === omitir) continue;
+    mkdirSync(join(raiz, dir), { recursive: true });
+    if (dir === vaciar) continue;
+    writeFileSync(join(raiz, dir, archivo), contenido);
+  }
+  return raiz;
+}
+
 describe("check-fixture-sizes", () => {
   it("exits 0 when all fixture sizes are within budget", () => {
-    const result = execFileSync(
-      "node",
-      [new URL("check-fixture-sizes.mjs", import.meta.url).pathname],
-      { encoding: "utf-8", cwd: new URL("..", import.meta.url).pathname },
-    );
-    assert.match(result, /All fixture size budgets are within limits/);
+    const { code, stdout } = correr(RAIZ);
+    assert.equal(code, 0);
+    assert.match(stdout, /All fixture size budgets are within limits/);
   });
 
   it("reports all three fixture groups", () => {
-    const result = execFileSync(
-      "node",
-      [new URL("check-fixture-sizes.mjs", import.meta.url).pathname],
-      { encoding: "utf-8", cwd: new URL("..", import.meta.url).pathname },
-    );
-    assert.match(result, /Receipt fixtures/);
-    assert.match(result, /Contract test snapshots/);
-    assert.match(result, /Demo trace outputs/);
+    const { stdout } = correr(RAIZ);
+    assert.match(stdout, /Receipt fixtures/);
+    assert.match(stdout, /Contract test snapshots/);
+    assert.match(stdout, /Demo trace outputs/);
+  });
+
+  it("passes on a temporary project where every required group is present", () => {
+    const raiz = proyecto();
+    try {
+      const { code } = correr(raiz);
+      assert.equal(code, 0, "un proyecto con los tres grupos completos tiene que pasar");
+    } finally {
+      rmSync(raiz, { recursive: true, force: true });
+    }
+  });
+
+  it("fails when a required group directory is missing", () => {
+    const raiz = proyecto({ omitir: "services/receipt-cli/src/fixtures" });
+    try {
+      const { code, stdout } = correr(raiz);
+      // Este es el agujero: antes salia [SKIP] y terminaba en 0, asi que
+      // borrar un grupo entero desactivaba su presupuesto sin que nadie viera.
+      assert.notEqual(code, 0, "un grupo ausente tiene que dar exit distinto de 0");
+      assert.match(stdout, /required fixture directory is missing/);
+      assert.match(stdout, /Receipt fixtures/);
+      assert.doesNotMatch(stdout, /\[SKIP\]/);
+    } finally {
+      rmSync(raiz, { recursive: true, force: true });
+    }
+  });
+
+  it("fails when a required group directory exists but has no matching files", () => {
+    const raiz = proyecto({ vaciar: "apps/web/src/demo" });
+    try {
+      const { code, stdout } = correr(raiz);
+      assert.notEqual(code, 0, "un grupo vacio tiene que dar exit distinto de 0");
+      assert.match(stdout, /has no matching files/);
+      assert.match(stdout, /Demo trace outputs/);
+    } finally {
+      rmSync(raiz, { recursive: true, force: true });
+    }
+  });
+
+  it("tells the two failure paths apart", () => {
+    // Se arreglan distinto: uno se restaura, el otro se repuebla. Un mensaje
+    // unico para los dos te obliga a ir a mirar cual fue.
+    const ausente = proyecto({ omitir: "contracts/round/test_snapshots/test" });
+    const vacio = proyecto({ vaciar: "contracts/round/test_snapshots/test" });
+    try {
+      assert.match(correr(ausente).stdout, /is missing/);
+      assert.match(correr(vacio).stdout, /has no matching files/);
+    } finally {
+      rmSync(ausente, { recursive: true, force: true });
+      rmSync(vacio, { recursive: true, force: true });
+    }
   });
 });