Skip to content

Commit d1dfe47

Browse files
committed
Simplify constructors using expression-bodied members
Replaced multi-line constructors with single-line expression-bodied members across several converter classes for improved readability and conciseness. Also adjusted method accessibility in NarratorCasingConverter to make `NarratorToUppercase` private.
1 parent 4f4a0e0 commit d1dfe47

File tree

3 files changed

+6
-15
lines changed

3 files changed

+6
-15
lines changed

source/HI2UC/Converters/NarratorCasingConverter.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@ public class NarratorCasingConverter : ICasingConverter
1212

1313
public IConverterStrategy ConverterStrategy { get; }
1414

15-
public NarratorCasingConverter(IConverterStrategy converterStrategy)
16-
{
17-
ConverterStrategy = converterStrategy;
18-
}
15+
public NarratorCasingConverter(IConverterStrategy converterStrategy) => ConverterStrategy = converterStrategy;
1916

2017
public void Convert(IList<Paragraph> paragraphs, ConverterContext converterContext)
2118
{
@@ -30,7 +27,7 @@ public void Convert(IList<Paragraph> paragraphs, ConverterContext converterConte
3027
}
3128
}
3229

33-
public string NarratorToUppercase(string text)
30+
private string NarratorToUppercase(string text)
3431
{
3532
var noTagText = HtmlUtils.RemoveTags(text, true).TrimEnd().TrimEnd('"');
3633

source/HI2UC/Converters/Strategies/TitleWordsConverter.cs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,10 @@ public class TitleWordsConverter : IConverterStrategy
99
private readonly ChunkReader _chunkReader;
1010
public string Name => "Title case (word)";
1111
public string Example => "foobar foobar => Foobar Foobar";
12-
13-
private readonly char[] _wordSplitChars = {' ' };
1412

15-
public TitleWordsConverter(ChunkReader chunkReader)
16-
{
17-
_chunkReader = chunkReader;
18-
}
13+
private readonly char[] _wordSplitChars = { ' ' };
14+
15+
public TitleWordsConverter(ChunkReader chunkReader) => _chunkReader = chunkReader;
1916

2017
public string Execute(string input)
2118
{

source/HI2UC/Converters/Strategies/UppercaseConverter.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@ public class UppercaseConverter : IConverterStrategy
1212

1313
public override string ToString() => Name;
1414

15-
public UppercaseConverter(ChunkReader chunkReader)
16-
{
17-
_chunkReader = chunkReader;
18-
}
15+
public UppercaseConverter(ChunkReader chunkReader) => _chunkReader = chunkReader;
1916

2017
public string Execute(string input)
2118
{

0 commit comments

Comments
 (0)