chore: make eslint happy

Author: SukkaW

packages/docs/src/app/layout.tsx

@@ -88,7 +88,7 @@ export const metadata: Metadata = {
   }
 };
 
-export default async function RootLayout({ children }: { children: React.ReactNode }) {
+export default async function RootLayout({ children }: React.PropsWithChildren) {
   const pageMap = await getPageMap();
 
   const navbar = (

packages/foxact/src/breadcrumbs/index.tsx

@@ -21,7 +21,7 @@ export interface BreadcrumbItemProps<T = unknown> {
 export interface BreadcrumbPageProps<T = unknown> {
   title: string,
   meta?: T,
-  // eslint-disable-next-line @typescript-eslint/no-restricted-types -- intentional, API shape
+  // eslint-disable-next-line @typescript-eslint/no-restricted-types, vibe-proof/react-no-render-function-prop -- intentional public API shape
   children: ((items: Array<BreadcrumbItemData<T>>) => React.ReactNode) | React.ReactElement
 }
 

packages/foxact/src/create-fixed-array/index.ts

@@ -1,3 +1,4 @@
+/* eslint-disable sukka/no-array-from-length-spread -- this module implements foxact/create-fixed-array */
 const arrayMap = new Map<number, readonly number[]>();
 
 function makeArray(length: number) {

packages/foxact/src/create-storage-hook/index.ts

@@ -192,8 +192,8 @@ export function createStorage(type: StorageType) {
 
     useLayoutEffect(() => {
       if (
-        getStorageItem(key) === null
-        && serverValue !== undefined
+        serverValue !== undefined
+        && getStorageItem(key) === null
       ) {
         setStorageItem(key, serializer(serverValue));
       }

packages/foxact/src/current-year/index.tsx

@@ -18,7 +18,7 @@ export const CurrentYear = memo(function CurrentYear({ defaultYear, ...restProps
   useIsomorphicLayoutEffect(() => {
     // This is only allowed because it won't trigger infinite re-render and double render is intentional
 
-    // eslint-disable-next-line @eslint-react/set-state-in-effect -- layout effect and only once
+    // eslint-disable-next-line @eslint-react/set-state-in-effect, vibe-proof/react-no-use-effect-watching -- hydration intentionally updates the SSR fallback once
     setYear(new Date().getFullYear());
   }, []);
 

packages/foxact/src/fetch-jsonp/index.ts

@@ -1,3 +1,5 @@
+import { invariant } from '../invariant';
+
 declare global {
   interface Window {
     __foxact_jsonp_callbacks__SECRET_INTERNAL_DO_NOT_USE_OR_YOU_WILL_BE_FIRED: Record<string, ((data: any) => void) | undefined>
@@ -8,9 +10,7 @@ const INTERNAL = '__foxact_jsonp_callbacks__SECRET_INTERNAL_DO_NOT_USE_OR_YOU_WI
 
 /** @see https://foxact.skk.moe/fetch-jsonp */
 export function fetchJsonp<T>(getUrl: (callbackName: string) => string, scriptElOptions?: Partial<HTMLScriptElement>): Promise<T> {
-  if (typeof window === 'undefined') {
-    throw new TypeError('fetchJsonp is only available in the browser');
-  }
+  invariant(typeof window !== 'undefined', 'fetchJsonp is only available in the browser');
 
   // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- initialization
   if (!window[INTERNAL]) {

packages/foxact/src/invariant/index.ts

@@ -1,5 +1,6 @@
 /** @see https://foxact.skk.moe/invariant-nullthrow */
 export function invariant<T>(value: T, message = '[foxact/invariant] "value" is null or undefined'): asserts value is NonNullable<T> {
+  // eslint-disable-next-line sukka/prefer-nullthrow -- this function defines foxact/invariant
   if (value === null || value === undefined) {
     throw new TypeError(message);
   }

packages/foxact/src/is-safari/index.ts

@@ -1,3 +1,6 @@
+const RE_SAFARI = /version\/[\d._].*?safari/i;
+const RE_MOBILE_SAFARI = /mobile safari [\d._]+/i;
+
 export function isSafari() {
   /* istanbul ignore if -- SSR-only guard, unreachable when Happy DOM registers window globally in tests */
   if (typeof window === 'undefined') {
@@ -11,11 +14,11 @@ export function isSafari() {
   if (typeof navigator.userAgent !== 'string') {
     return false;
   }
-  if (/version\/[\d._].*?safari/i.test(navigator.userAgent)) {
+  if (RE_SAFARI.test(navigator.userAgent)) {
     return true;
   }
-  // eslint-disable-next-line sukka/unicorn/prefer-boolean-return -- cleaner code
-  if (/mobile safari [\d._]+/i.test(navigator.userAgent)) {
+
+  if (RE_MOBILE_SAFARI.test(navigator.userAgent)) {
     return true;
   }
   return false;

packages/foxact/src/merge-props/index.test.ts

@@ -115,7 +115,9 @@ describe('mergeProps', () => {
   });
 
   it('handles non-standard event handlers without error', () => {
-    for (const eventArgument of [true, 13, 'newValue', { key: 'value' }, ['value'], () => 'value']) {
+    const eventArguments = [true, 13, 'newValue', { key: 'value' }, ['value'], () => 'value'];
+    for (let i = 0, len = eventArguments.length; i < len; i++) {
+      const eventArgument = eventArguments[i];
       const log: string[] = [];
 
       const mergedProps = mergeProps<any>(

packages/foxact/src/merge-props/index.ts

@@ -59,7 +59,7 @@ function mutablyMergeInto<T extends React.ElementType>(
   }
 
   const keys = Object.keys(externalProps);
-  for (let i = 0; i < keys.length; i++) {
+  for (let i = 0, len = keys.length; i < len; i++) {
     const propName = keys[i];
     const externalPropValue = (externalProps as Record<string, unknown>)[propName];