Skip to content

Commit f268b78

Browse files
committed
test: improve assertions and add new tests
1 parent 8d3c3a9 commit f268b78

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

tests/test_file.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ def setUp(self):
1212
self.project = scubatrace.Project.create(
1313
str(self.project_path), language=scubatrace.language.C
1414
)
15-
self.file = self.project.files.get("main.c")
15+
file = self.project.files.get("main.c")
16+
assert file is not None
17+
self.file = file
1618

1719
def test_file_create(self):
1820
file = scubatrace.File.create(
@@ -22,35 +24,30 @@ def test_file_create(self):
2224
self.assertIsNotNone(file)
2325

2426
def test_file_imports(self):
25-
assert self.file is not None
2627
imports = self.file.imports
2728
self.assertGreater(len(imports), 0)
2829
for imp in imports:
2930
self.assertTrue(imp.name in ["stdio.h", "sub.h"])
3031

3132
def test_file_functions(self):
32-
assert self.file is not None
3333
functions = self.file.functions
3434
self.assertGreater(len(functions), 0)
3535
for func in functions:
3636
self.assertIsNotNone(func.name)
3737

3838
def test_file_function_by_line(self):
39-
assert self.file is not None
4039
function = self.file.function_by_line(5)
4140
self.assertIsNotNone(function)
4241
assert function is not None
4342
self.assertEqual(function.name, "add")
4443

4544
def test_file_statements(self):
46-
assert self.file is not None
4745
statements = self.file.statements
4846
self.assertGreater(len(statements), 0)
4947
for stmt in statements:
5048
self.assertIsNotNone(stmt.text)
5149

5250
def test_file_statement_by_line(self):
53-
assert self.file is not None
5451
statements = self.file.statements_by_line(14)
5552
self.assertGreater(len(statements), 0)
5653
statement = statements[0]
@@ -61,14 +58,12 @@ def test_file_statement_by_line(self):
6158
self.assertGreater(len(self.file.statements_by_line(1)), 0)
6259

6360
def test_file_identifiers(self):
64-
assert self.file is not None
6561
identifiers = self.file.identifiers
6662
self.assertGreater(len(identifiers), 0)
6763
for identifier in identifiers:
6864
self.assertIsNotNone(identifier.name)
6965

7066
def test_file_variables(self):
71-
assert self.file is not None
7267
variables = self.file.variables
7368
self.assertGreater(len(variables), 0)
7469
for var in variables:
@@ -82,7 +77,6 @@ def test_file_cfg(self):
8277
self.assertGreater(len(cfg.edges), 0)
8378

8479
def test_file_query(self):
85-
assert self.file is not None
8680
query_str = """
8781
(call_expression
8882
function: (identifier)@func

tests/test_function.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,17 @@ def setUp(self):
1414
)
1515
self.file = self.project.files.get("main.c")
1616
assert self.file is not None
17-
self.function = self.file.function_by_line(11)
17+
function = self.file.function_by_line(11)
18+
assert function is not None
19+
self.function = function
1820

1921
def test_function_create(self):
20-
assert self.function is not None
2122
function = scubatrace.Function.create(self.function.node, self.function.parent)
2223
self.assertIsNotNone(function)
24+
25+
def test_function_lines(self):
26+
self.assertGreater(len(self.function.lines), 0)
27+
28+
def test_function_parameter_lines(self):
29+
self.assertEqual(len(self.function.parameter_lines), 1)
30+
self.assertEqual(self.function.parameter_lines[0], 9)

tests/test_statement.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ def setUp(self):
2121
self.statement = statement[0]
2222

2323
def test_statement_create(self):
24-
assert self.statement is not None
2524
statement = scubatrace.SimpleStatement.create(
2625
self.statement.node, self.statement.parent
2726
)

0 commit comments

Comments
 (0)