Skip to content

Commit 2b305f3

Browse files
authored
Angular upgrade to v19 and critical vuln fixes (#183)
* #SS-I12: fix - ng 19 upgrade * #SS-I12: fix - ng 19 upgrade * #SS-I12: fix - ng 19 upgrade * #SS-I12: fix - ng 19 upgrade * #SS-I21: fix - angular upgrade to 19 * #SS-I21: fix - removed unused workflow * #SS-I21: fix - linting fix
1 parent 1bb5099 commit 2b305f3

25 files changed

Lines changed: 12424 additions & 16700 deletions

.circleci/config.yml

Lines changed: 0 additions & 51 deletions
This file was deleted.

.eslintrc.json

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,40 @@
4646
"plugin:@angular-eslint/template/recommended"
4747
],
4848
"rules": {}
49+
},
50+
{
51+
"files": [
52+
"projects/sunbird-video-player/**/*.ts"
53+
],
54+
"parserOptions": {
55+
"project": [
56+
"projects/sunbird-video-player/tsconfig.lib.json",
57+
"projects/sunbird-video-player/tsconfig.spec.json"
58+
],
59+
"createDefaultProgram": true
60+
},
61+
"extends": [
62+
"plugin:@angular-eslint/recommended",
63+
"plugin:@angular-eslint/template/process-inline-templates",
64+
"plugin:@typescript-eslint/recommended"
65+
],
66+
"rules": {}
67+
},
68+
{
69+
"files": [
70+
"projects/video-player-wc/**/*.ts"
71+
],
72+
"parserOptions": {
73+
"project": [
74+
"projects/video-player-wc/tsconfig.app.json",
75+
"projects/video-player-wc/tsconfig.spec.json"
76+
],
77+
"createDefaultProgram": true
78+
},
79+
"extends": [
80+
"plugin:@angular-eslint/recommended"
81+
],
82+
"rules": {}
4983
}
5084
]
5185
}

.github/workflows/jira-description-action.yml

Lines changed: 0 additions & 16 deletions
This file was deleted.

.github/workflows/publish_module.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ jobs:
1515
- name: Set up Node.js
1616
uses: actions/setup-node@v4
1717
with:
18-
node-version: '22.15.0'
18+
node-version: '22.21.1'
1919

2020
- name: Install dependencies
21-
run: npm ci --legacy-peer-deps
21+
run: npm i --legacy-peer-deps
2222

2323
- name: Build and publish package
2424
env:
@@ -27,5 +27,5 @@ jobs:
2727
npm run build-lib
2828
npm pack ./dist/sunbird-video-player
2929
echo "//registry.npmjs.org/:_authToken=${NODE_AUTH_TOKEN}" > ~/.npmrc
30-
npm publish project-sunbird-sunbird-video-player-v9-*
30+
npm publish project-sunbird-sunbird-video-player-v9-* --access public
3131

.github/workflows/publish_web_component.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ jobs:
1515
- name: Set up Node.js
1616
uses: actions/setup-node@v4
1717
with:
18-
node-version: '22.15.0'
18+
node-version: '22.21.1'
1919

2020
- name: Install dependencies
21-
run: npm ci --legacy-peer-deps
21+
run: npm i --legacy-peer-deps
2222

2323
- name: Build and publish package
2424
env:

assets-copy.js

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
11
const fs = require('fs-extra');
22
(async () => {
33
try {
4-
var source = "projects/sunbird-video-player/node_modules/@project-sunbird/sunbird-player-sdk-v9/lib/assets";
5-
const dest = "dist/sunbird-video-player/lib/assets/";
6-
const isAssetsExists = await fs.pathExists(dest)
7-
var libsource = "projects/sunbird-video-player/src/lib/assets";
8-
if (isAssetsExists) {
9-
await fs.remove(dest);
10-
}
11-
await fs.ensureDir(dest);
12-
await fs.copy(source, dest)
13-
await fs.copy(libsource, dest)
4+
var source = "projects/sunbird-video-player/node_modules/@project-sunbird/sunbird-player-sdk-v9/lib/assets";
5+
const dest = "dist/sunbird-video-player/lib/assets/";
6+
const isAssetsExists = await fs.pathExists(dest)
7+
var libsource = "projects/sunbird-video-player/src/lib/assets";
8+
if (isAssetsExists) {
9+
await fs.remove(dest);
10+
}
11+
await fs.ensureDir(dest);
12+
const isSdkAssetsExists = await fs.pathExists(source);
13+
if (isSdkAssetsExists) {
14+
await fs.copy(source, dest);
15+
}
16+
await fs.copy(libsource, dest)
1417
console.log('Assets copied successfully')
1518
} catch (err) {
1619
console.error("Error while copying assets", err)

build-wc.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,16 @@ const build = async () => {
1616
"projects/sunbird-video-player/src/lib/assets/videojs.markers.min.css",
1717
];
1818
await fs.ensureDir("dist/video-player-wc");
19+
await fs.ensureDir("dist/video-player-wc/assets");
20+
await fs.copy("projects/sunbird-video-player/src/lib/assets", "dist/video-player-wc/assets");
1921
// make signle js file for web component
2022
await concat(files, "web-component/sunbird-video-player.js");
2123
await fs.copy("./dist/video-player-wc/assets", "web-component/assets");
24+
// keep the demo bundle and assets in sync with the latest build
25+
await fs.ensureDir("web-component-demo");
26+
await fs.copy("web-component/sunbird-video-player.js", "web-component-demo/sunbird-video-player.js");
27+
await fs.copy("web-component/styles.css", "web-component-demo/styles.css");
28+
await fs.copy("web-component/assets", "web-component-demo/assets");
2229
const assetFilesToBeDeleted = ["videojs-markers.js", "videojs-transcript-click.min.js", "videojs.markers.min.css"]
2330

2431
assetFilesToBeDeleted.forEach(async (file) => {

0 commit comments

Comments
 (0)