Skip to content

Commit 74d34d6

Browse files
committed
made some changes according to coderabbit review
1 parent ffaa157 commit 74d34d6

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

src/helpers/gear.cairo

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,13 @@ pub fn get_min_xp_needed(gear_type: GearType) -> u256 {
169169

170170
// Helper function to generate random GearDetails
171171
pub fn random_gear_details() -> GearDetails {
172-
let gear_type = random_geartype();
172+
let mut gear_type = random_geartype();
173+
174+
if gear_type == GearType::None {
175+
// Fallback to a sane default; alternatively re-roll with a different seed.
176+
gear_type = GearType::Weapon;
177+
}
178+
173179
let min_xp_needed = get_min_xp_needed(gear_type);
174180
let max_upgrade_level = get_max_upgrade_level(gear_type);
175181

src/systems/core.cairo

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ pub mod CoreActions {
106106
owner: contract_address_const::<0>(),
107107
max_upgrade_level: details.max_upgrade_level,
108108
min_xp_needed: details.min_xp_needed,
109-
spawned: true,
109+
spawned: false,
110110
};
111111

112112
assert(!gear.spawned, 'Gear already spawned');

0 commit comments

Comments
 (0)