fix: cannot install MCP Servers when running "SuperGemini install".

Author: Hyungu Cho

Docs/Reference/diagnostic-reference.md

@@ -580,7 +580,7 @@ def time_operation(command, description):
     """Time a shell command and return duration"""
     start_time = time.time()
     try:
-        result = subprocess.run(command, shell=True, capture_output=True, text=True, timeout=30)
+        result = subprocess.run(command, shell=(sys.platform == "win32"), capture_output=True, text=True, timeout=30)
         end_time = time.time()
         duration = end_time - start_time
         success = result.returncode == 0
@@ -1011,4 +1011,4 @@ EOF
 
 **Diagnostic Philosophy**: Approach problems systematically - start with basic verification, isolate components, test hypotheses, and apply targeted solutions. Document findings for future reference and community benefit.
 
-**Emergency Contact**: For critical system failures, use the complete recovery protocol above. If issues persist after recovery, document the full diagnostic output and seek community support through GitHub issues.
+**Emergency Contact**: For critical system failures, use the complete recovery protocol above. If issues persist after recovery, document the full diagnostic output and seek community support through GitHub issues.

setup/components/mcp.py

@@ -340,7 +340,7 @@ def _install_npm_package(self, server_key: str, server_info: Dict[str, Any]) ->
                 capture_output=True,
                 text=True,
                 timeout=180,
-                shell=True
+                shell=(sys.platform == "win32")
             )
 
             if result.returncode == 0:
@@ -373,7 +373,7 @@ def _install_uv_package(self, server_key: str, server_info: Dict[str, Any]) -> b
                 capture_output=True,
                 text=True,
                 timeout=300,
-                shell=True
+                shell=(sys.platform == "win32")
             )
 
             if result.returncode == 0:
@@ -411,7 +411,7 @@ def _verify_npm_installation(self, server_key: str, server_info: Dict[str, Any])
                 capture_output=True,
                 text=True,
                 timeout=30,
-                shell=True
+                shell=(sys.platform == "win32")
             )
 
             if result.returncode == 0:
@@ -434,7 +434,7 @@ def _verify_uv_installation(self, server_key: str, server_info: Dict[str, Any])
                 capture_output=True,
                 text=True,
                 timeout=30,
-                shell=True
+                shell=(sys.platform == "win32")
             )
 
             if result.returncode == 0 and ("serena" in result.stdout or "serena-agent" in result.stdout):
@@ -454,7 +454,7 @@ def _validate_prerequisites(self) -> Tuple[bool, List[str]]:
 
         # Check Node.js version (>=18 required for MCP)
         try:
-            result = subprocess.run(["node", "--version"], capture_output=True, text=True, timeout=10, shell=True)
+            result = subprocess.run(["node", "--version"], capture_output=True, text=True, timeout=10, shell=(sys.platform == "win32"))
             if result.returncode == 0:
                 version = result.stdout.strip().lstrip('v')
                 major_version = int(version.split('.')[0])
@@ -469,7 +469,7 @@ def _validate_prerequisites(self) -> Tuple[bool, List[str]]:
 
         # Check npm availability
         try:
-            result = subprocess.run(["npm", "--version"], capture_output=True, text=True, timeout=10, shell=True)
+            result = subprocess.run(["npm", "--version"], capture_output=True, text=True, timeout=10, shell=(sys.platform == "win32"))
             if result.returncode != 0:
                 errors.append("npm not working properly")
             else:
@@ -479,7 +479,7 @@ def _validate_prerequisites(self) -> Tuple[bool, List[str]]:
 
         # Check uv availability (for Python-based MCP servers like Serena)
         try:
-            result = subprocess.run(["uv", "--version"], capture_output=True, text=True, timeout=10, shell=True)
+            result = subprocess.run(["uv", "--version"], capture_output=True, text=True, timeout=10, shell=(sys.platform == "win32"))
             if result.returncode == 0:
                 self.logger.debug(f"uv {result.stdout.strip()} OK")
             else:
@@ -756,4 +756,4 @@ def get_dependencies(self) -> List[str]:
 
     def get_size_estimate(self) -> int:
         """Get estimated size - minimal since we only modify config"""
-        return 4096  # 4KB - just config modifications
+        return 4096  # 4KB - just config modifications