fix(realtime/presence): return promise in get all

Author: Raspincel

src/components/realtime/presence.test.ts

@@ -1,4 +1,4 @@
-import { PresenceEvents, Room } from '../../lib/socket';
+import { PresenceEvent, PresenceEvents, Room } from '../../lib/socket';
 
 import { RealtimePresence } from './presence';
 import { MOCK_IO } from '../../../__mocks__/io.mock';
@@ -55,5 +55,18 @@ describe('realtime component', () => {
 
       expect(spy).toHaveBeenCalled();
     });
+
+    test('should get all presences and resolve', async () => {
+      RealtimePresenceInstance['room'].presence.get = jest.fn((callback) => {
+        callback([{ id: '123', name: 'John Doe' }] as PresenceEvent[]);
+      });
+      const presences = RealtimePresenceInstance['getAll']();
+
+      expect(presences instanceof Promise).toBe(true);
+
+      const data = await presences;
+
+      expect(data).toEqual([{ id: '123', name: 'John Doe' }]);
+    });
   });
 });

src/components/realtime/presence.ts

@@ -24,19 +24,18 @@ export class RealtimePresence {
     this.room.presence.off(event);
   }
 
-  public getAll() {
+  public async getAll() {
     this.logger.log('Realtime Presence @ get all');
-    let presences: Socket.PresenceEvent[] = [];
-    this.room.presence.get(
-      (data) => {
-        presences = data;
-      },
-      (error) => {
-        const message = `[SuperViz] ${error.name} - ${error.message}`;
-        this.logger.log(error);
-        console.error(message);
-      },
-    );
-    return presences;
+    return new Promise((resolve, reject) => {
+      this.room.presence.get(
+        (data) => resolve(data),
+        (error) => {
+          const message = `[SuperViz] ${error.name} - ${error.message}`;
+          this.logger.log(error);
+          console.error(message);
+          reject(error);
+        },
+      );
+    });
   }
 }