Skip to content

Commit 0fbea39

Browse files
committed
fix issues after merge!
1 parent b3079a8 commit 0fbea39

4 files changed

Lines changed: 5 additions & 12 deletions

File tree

load_corpus.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,6 @@
159159
else:
160160
print(".......unknown feature list format. Ignoring.......")
161161

162-
elif args.config:
163-
# Load from new-style JSON config file
164-
config = Config.from_json(args.config)
165-
# Override paths if provided via CLI
166-
if args.s:
167-
config.corpus.paths = args.s
168162

169163
else:
170164
if not args.s:

superstyl/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ def validate(self) -> None:
244244
raise ValueError("No paths specified for corpus loading.")
245245

246246
# Validate paths type
247-
if not isinstance(self.corpus.paths, list):
247+
if not isinstance(self.corpus.paths, (list, str)):
248248
raise TypeError("Paths in config must be either a list or a glob pattern string.")
249249

250250
for feat_config in self.features:

superstyl/load.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@
66
import pandas
77
from typing import Optional, List, Tuple, Union
88

9-
from superstyl.config import Config, FeatureConfig, NormalizationConfig
9+
from superstyl.config import Config, FeatureConfig
1010

1111

1212
def _load_single_feature(
1313
myTexts: List[dict],
1414
feat_config: FeatureConfig,
15-
norm_config: NormalizationConfig,
1615
use_provided_feat_list: bool = False,
1716
) -> Tuple[pandas.DataFrame, List]:
1817
"""
@@ -183,7 +182,7 @@ def load_corpus(
183182
if len(config.features) == 1:
184183
feat_config = config.features[0]
185184
feats_df, feat_list = _load_single_feature(
186-
myTexts, feat_config, config.normalization, use_provided_feat_list
185+
myTexts, feat_config, use_provided_feat_list
187186
)
188187
corpus = pandas.concat([metadata, feats_df], axis=1)
189188
return corpus, feat_list
@@ -199,7 +198,7 @@ def load_corpus(
199198
print(f".......processing {prefix}.......")
200199

201200
feats_df, feat_list = _load_single_feature(
202-
myTexts, feat_config, config.normalization, use_provided_feat_list
201+
myTexts, feat_config, use_provided_feat_list
203202
)
204203

205204
# Prefix columns to avoid collisions

superstyl/preproc/pipe.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ def extract_tokens(path: str, config: Config=Config()) -> List[str]:
297297
return nltk.tokenize.wordpunct_tokenize(text)
298298

299299
elif config.corpus.format == "tei":
300-
return LOADERS['tei'].extract_units(path, config.corpus.units, feats)
300+
return LOADERS['tei'].extract_units(path, config.sampling.units, feats)
301301

302302
elif config.sampling.units == "verses" and config.corpus.format == "txm":
303303
return LOADERS['txm'].extract_units(path, config.sampling.units, feats)

0 commit comments

Comments
 (0)