READY: Fix wca and willbe (Wandalen#1540)

* fix clippy

* fix clippy

Author: SupperZum

module/core/former_meta/src/derive_former.rs

@@ -93,7 +93,7 @@ r"derive : Former
 item : {item}",
     );
     diag::report_print( about, original_input, debug );
-  };
+  }
 
   Ok( former_mutator_code )
 }

module/core/former_meta/src/derive_former/former_enum.rs

@@ -123,7 +123,7 @@ specific needs of the broader forming context. It mandates the implementation of
   let ( perform, perform_output, perform_generics ) = struct_attrs.performer()?;
 
   /* fields: Process struct fields and storage_fields attribute. */
-  let fields = derive::named_fields( &ast )?;
+  let fields = derive::named_fields( ast )?;
   // Create FormerField representation for actual struct fields.
   let formed_fields : Vec< _ > = fields
   .iter()
@@ -226,7 +226,7 @@ specific needs of the broader forming context. It mandates the implementation of
     field.former_field_setter
     (
       item,
-      &original_input,
+      original_input,
       &struct_generics_impl,
       &struct_generics_ty,
       &struct_generics_where,
@@ -244,7 +244,7 @@ specific needs of the broader forming context. It mandates the implementation of
   // Collect preform logic results.
   let storage_field_preform : Vec< _ > = storage_field_preform.into_iter().collect::< Result< _ > >()?;
   // Generate mutator implementation code.
-  let former_mutator_code = mutator( item, &original_input, &struct_attrs.mutator, &former_definition_types, &former_definition_types_generics_impl, &former_definition_types_generics_ty, &former_definition_types_generics_where )?;
+  let former_mutator_code = mutator( item, original_input, &struct_attrs.mutator, &former_definition_types, &former_definition_types_generics_impl, &former_definition_types_generics_ty, &former_definition_types_generics_where )?;
 
   // <<< Start of updated code for standalone constructor >>>
   let standalone_constructor_code = if struct_attrs.standalone_constructors.value( false )

module/core/former_meta/src/derive_former/former_struct.rs

@@ -193,8 +193,8 @@ impl< Definition : crate::FormerDefinitionTypes > FormingEndClosure< Definition
   /// # Parameters
   ///
   /// * `closure` - A closure that matches the expected signature for transforming a collection
-  ///               and context into a new context. This closure is stored and called by the
-  ///               `call` method of the `FormingEnd` trait implementation.
+  ///   and context into a new context. This closure is stored and called by the
+  ///   `call` method of the `FormingEnd` trait implementation.
   ///
   /// # Returns
   ///

module/core/former_types/src/forming.rs

@@ -29,6 +29,7 @@ mod private
   /// assert_eq!( got_normal.to_string(), "my_var" );
   /// assert_eq!( got_keyword.to_string(), "r#fn" );
   /// ```
+  #[must_use]
   pub fn ident_maybe_raw( ident : &syn::Ident ) -> Ident
   {
     let name = ident.to_string();

module/core/macro_tools/src/ident.rs

@@ -76,7 +76,7 @@ mod private
       },
       // Do nothing for unit structs
       syn::Fields::Unit => {}
-    };
+    }
 
     new_input
   }

module/core/macro_tools/src/item.rs

@@ -110,7 +110,7 @@ mod private
             }
           )
       }
-    };
+    }
 
     input
   }

module/core/macro_tools/src/phantom.rs

@@ -58,8 +58,8 @@ mod private
   /// ```
   /// # Panics
   /// qqq: doc
-  #[ allow( clippy::cast_possible_wrap ) ]
-  pub fn type_parameters< 'a >( ty : &'a syn::Type, range : impl NonIterableInterval ) -> Vec< &'a syn::Type >
+  #[ allow( clippy::cast_possible_wrap, clippy::needless_pass_by_value ) ]
+  pub fn type_parameters( ty : &syn::Type, range : impl NonIterableInterval ) -> Vec< &syn::Type >
   {
     if let syn::Type::Path( syn::TypePath{ path : syn::Path { ref segments, .. }, .. } ) = ty
     {

module/core/macro_tools/src/typ.rs

@@ -496,7 +496,7 @@ mod private
             syn::Result::Ok( () )
           })?;
         }
-      };
+      }
 
       syn::Result::Ok( () )
     })?;

module/core/mod_interface_meta/src/impls.rs

@@ -82,7 +82,7 @@ mod private
           {
             return Err( syn_err!( "Complex group uses like `use module1::{ module2, module3 }` are not supported." ) );
           },
-        };
+        }
       }
 
       Ok( path )
@@ -187,7 +187,7 @@ mod private
             group = true;
             break;
           },
-        };
+        }
       }
 
       Ok( Self