Skip to content

Commit 4ebc2fa

Browse files
committed
Removed few lint warnings; [Release]increased version code;
1 parent 22b7cbe commit 4ebc2fa

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ android {
99
vectorDrawables.useSupportLibrary = true
1010
minSdkVersion 19
1111
targetSdkVersion 27
12-
versionCode 6
13-
versionName "2.3"
12+
versionCode 8
13+
versionName "2.5"
1414
}
1515
buildTypes {
1616
release {

app/src/main/java/swati4star/createpdf/adapter/ViewFilesAdapter.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import butterknife.BindView;
4242
import butterknife.ButterKnife;
4343
import swati4star.createpdf.R;
44-
import swati4star.createpdf.fragment.ViewFilesFragment;
4544

4645

4746
/**

app/src/main/java/swati4star/createpdf/fragment/ViewFilesFragment.java

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public class ViewFilesFragment extends Fragment
4646
private static final int SIZE_INCREASING_ORDER_INDEX = 2;
4747
private static final int SIZE_DECREASING_ORDER_INDEX = 3;
4848
private Activity mActivity;
49-
ViewFilesAdapter mViewFilesAdapter;
49+
private ViewFilesAdapter mViewFilesAdapter;
5050
@BindView(R.id.filesRecyclerView)
5151
RecyclerView mViewFilesListRecyclerView;
5252
@BindView(R.id.swipe)
@@ -310,14 +310,19 @@ private void populateListView() {
310310
pdfFiles = getPdfsFromPdfFolder();
311311
}
312312
Log.v("done", "adding");
313-
if (mCurrentSortingIndex == NAME_INDEX) {
314-
sortByNameAlphabetical(pdfFiles);
315-
} else if (mCurrentSortingIndex == DATE_INDEX) {
316-
sortFilesByDateNewestToOldest(pdfFiles);
317-
} else if (mCurrentSortingIndex == SIZE_INCREASING_ORDER_INDEX) {
318-
sortFilesBySizeIncreasingOrder(pdfFiles);
319-
} else if (mCurrentSortingIndex == SIZE_DECREASING_ORDER_INDEX) {
320-
sortFilesBySizeDecreasingOrder(pdfFiles);
313+
switch (mCurrentSortingIndex) {
314+
case NAME_INDEX:
315+
sortByNameAlphabetical(pdfFiles);
316+
break;
317+
case DATE_INDEX:
318+
sortFilesByDateNewestToOldest(pdfFiles);
319+
break;
320+
case SIZE_INCREASING_ORDER_INDEX:
321+
sortFilesBySizeIncreasingOrder(pdfFiles);
322+
break;
323+
case SIZE_DECREASING_ORDER_INDEX:
324+
sortFilesBySizeDecreasingOrder(pdfFiles);
325+
break;
321326
}
322327
mViewFilesAdapter.setData(pdfFiles);
323328
mViewFilesListRecyclerView.setAdapter(mViewFilesAdapter);

0 commit comments

Comments
 (0)