Skip to content

Commit a0c858f

Browse files
authored
few playstore reported crash fixes (#475)
1 parent 2d56144 commit a0c858f

File tree

6 files changed

+15
-8
lines changed

6 files changed

+15
-8
lines changed

app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ android {
1010
minSdkVersion 21
1111
multiDexEnabled true
1212
targetSdkVersion 27
13-
versionCode 53
14-
versionName "8.0.0"
13+
versionCode 58
14+
versionName "8.3.1"
1515
}
1616
buildTypes {
1717
release {

app/src/main/java/swati4star/createpdf/adapter/ViewFilesAdapter.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,8 @@ public void unCheckAll() {
189189
public ArrayList<String> getSelectedFilePath() {
190190
ArrayList<String> filePathList = new ArrayList<>();
191191
for (int position : mSelectedFiles) {
192-
filePathList.add(mFileList.get(position).getPath());
192+
if (mFileList.size() > position)
193+
filePathList.add(mFileList.get(position).getPath());
193194
}
194195
return filePathList;
195196
}
@@ -286,7 +287,8 @@ public void deleteFiles() {
286287
public void shareFiles() {
287288
ArrayList<File> files = new ArrayList<>();
288289
for (int position : mSelectedFiles) {
289-
files.add(mFileList.get(position));
290+
if (mFileList.size() > position)
291+
files.add(mFileList.get(position));
290292
}
291293
mFileUtils.shareMultipleFiles(files);
292294
}

app/src/main/java/swati4star/createpdf/fragment/RemovePagesFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ public void pdfCompressionStarted() {
252252
@Override
253253
public void pdfCompressionEnded(String path, Boolean success) {
254254
mMaterialDialog.dismiss();
255-
if (success) {
255+
if (success && path != null) {
256256
getSnackbarwithAction(mActivity, R.string.snackbar_pdfCreated)
257257
.setAction(R.string.snackbar_viewAction, v -> mFileUtils.openFile(path)).show();
258258
new DatabaseHelper(mActivity).insertRecord(path,

app/src/main/java/swati4star/createpdf/fragment/TextToPdfFragment.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -395,13 +395,13 @@ public void onRequestPermissionsResult(int requestCode,
395395

396396
private void onPasswordAdded() {
397397
mTextEnhancementOptionsEntityArrayList.get(3)
398-
.setImage(getResources().getDrawable(R.drawable.baseline_done_24));
398+
.setImage(mActivity.getResources().getDrawable(R.drawable.baseline_done_24));
399399
mTextEnhancementOptionsAdapter.notifyDataSetChanged();
400400
}
401401

402402
private void onPasswordRemoved() {
403403
mTextEnhancementOptionsEntityArrayList.get(3)
404-
.setImage(getResources().getDrawable(R.drawable.baseline_enhanced_encryption_24));
404+
.setImage(mActivity.getResources().getDrawable(R.drawable.baseline_enhanced_encryption_24));
405405
mTextEnhancementOptionsAdapter.notifyDataSetChanged();
406406
}
407407

app/src/main/java/swati4star/createpdf/util/DirectoryUtils.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ private int checkChar(String query , String fileName) {
8080
*/
8181
public ArrayList<File> getPdfsFromPdfFolder(File[] files) {
8282
ArrayList<File> pdfFiles = new ArrayList<>();
83+
if (files == null)
84+
return pdfFiles;
8385
for (File file : files) {
8486
if (isPDFAndNotDirectory(file))
8587
pdfFiles.add(file);

app/src/main/java/swati4star/createpdf/util/FileUtils.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@ public void openFile(String path) {
195195
File file = new File(path);
196196
Intent target = new Intent(Intent.ACTION_VIEW);
197197
target.setFlags(Intent.FLAG_ACTIVITY_NO_HISTORY);
198-
199198
try {
200199
Uri uri = FileProvider.getUriForFile(mContext, AUTHORITY_APP, file);
201200
target.setDataAndType(uri, mContext.getString(R.string.pdf_type));
@@ -232,6 +231,10 @@ public int checkRepeat(String finalOutputFile, final ArrayList<File> mFile) {
232231
*/
233232
public String getUriRealPath(Uri uri) {
234233
String ret;
234+
235+
if (uri == null)
236+
return null;
237+
235238
if (isWhatsappImage(uri.getAuthority())) {
236239
ret = null;
237240
} else {

0 commit comments

Comments
 (0)