Skip to content

Commit 1b6f387

Browse files
committed
feat: add support links and planned manifest.yml contact requirement
1 parent eafcb55 commit 1b6f387

File tree

9 files changed

+2841
-2785
lines changed

9 files changed

+2841
-2785
lines changed

dist/appverse.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/appverse.es.js

Lines changed: 2773 additions & 2746 deletions
Large diffs are not rendered by default.

dist/appverse.es.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/appverse.umd.js

Lines changed: 27 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/appverse.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/app-review-checklist.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ All of these must be met for inclusion. These are pass/fail.
3737

3838
| Check | What to Look For |
3939
|-------|------------------|
40-
| `manifest.yml` exists | Has `name`, `category`, `role`, `description` at minimum |
40+
| `manifest.yml` exists | Has `name`, `category`, `role`, `description` at minimum. **Planned:** `contact` or `support_url` will become required — apps without one won't be listed. |
4141
| `README.md` exists | Is substantive (not just a title) — see Documentation section |
4242
| `LICENSE` exists | Open source license present (MIT recommended) |
4343

@@ -203,7 +203,7 @@ Copy this template when reviewing a new app submission:
203203
**Date:** [Date]
204204

205205
### Required Criteria
206-
- [ ] manifest.yml with required fields
206+
- [ ] manifest.yml with required fields (planned: `contact` or `support_url` will be required)
207207
- [ ] README.md (substantive)
208208
- [ ] LICENSE (open source)
209209
- [ ] Standard OOD app structure

docs/appverse-contributor-guide.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@ metadata:
111111
field_of_science: Chemistry # Additional categorization of research domain
112112
```
113113
114+
> **Planned requirement:** A `contact` or `support_url` field will be added to `manifest.yml` as a required field. Apps without a contact or support URL will not be listed in the catalog. This ensures deployers always know where to get help or report issues. Details TBD — watch the [Appverse affinity group](https://ondemand.connectci.org/affinity-groups/ood-appverse) for updates.
115+
114116
See the [OOD manifest.yml reference](https://osc.github.io/ood-documentation/latest/how-tos/app-development/interactive/manifest.html) for full details.
115117

116118
### The README

src/components/detail/AppRow.jsx

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,21 @@ export default function AppRow({ app, isExpanded, onToggle }) {
7777
</a>
7878
);
7979

80+
const ReportIssueButton = () => githubUrl && (
81+
<a
82+
href={`${githubUrl}/issues`}
83+
target="_blank"
84+
rel="noopener noreferrer"
85+
onClick={() => track('report_issue', { app_title: title, github_url: githubUrl })}
86+
className="inline-flex items-center gap-2 text-appverse-black visited:text-appverse-black hover:text-gray-600 transition-colors font-sans font-semibold text-sm whitespace-nowrap"
87+
>
88+
<span className="grid place-items-center w-5 h-5 rounded-full bg-appverse-red">
89+
<ChevronRight className="w-3.5 h-3 text-white" style={{ stroke: 'white', strokeWidth: 1, transform: 'translateX(0.5px)' }} />
90+
</span>
91+
REPORT AN ISSUE
92+
</a>
93+
);
94+
8095
const ShowReadmeButton = ({ className = '' }) => readme && (
8196
<button
8297
onClick={() => {
@@ -135,9 +150,10 @@ export default function AppRow({ app, isExpanded, onToggle }) {
135150
<TagList />
136151
</div>
137152

138-
{/* Right column: view repo + stats box */}
153+
{/* Right column: view repo, report issue + stats box */}
139154
<div className="flex flex-col gap-2 flex-shrink-0 items-start">
140155
<ViewRepoButton />
156+
<ReportIssueButton />
141157
<div className="bg-appverse-gray/30 rounded px-3 py-2 text-sm font-sans text-appverse-black min-w-[160px]">
142158
<p className="flex items-center gap-1">
143159
<span className="font-bold">{githubStars}</span> <StarFill className="w-3 h-3" /> on GitHub
@@ -176,6 +192,7 @@ export default function AppRow({ app, isExpanded, onToggle }) {
176192
{/* Action buttons */}
177193
<div className="flex flex-row flex-wrap gap-4">
178194
<ViewRepoButton />
195+
<ReportIssueButton />
179196
<ShowReadmeButton />
180197
</div>
181198
</div>

src/pages/SoftwareHome.jsx

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -224,12 +224,22 @@ export default function SoftwareHome() {
224224
The Open OnDemand Appverse is a community-driven catalog of scientific software, interactive applications, dashboards, and widgets with shared deployment configurations that HPC centers can use to extend their Open OnDemand portals.
225225
</p> */}
226226
</div>
227-
<a
228-
href="/node/add/appverse_app"
229-
className="w-full lg:w-auto text-center lg:flex-shrink-0 py-3 px-6 bg-appverse-red text-white font-sans font-semibold rounded-appverse hover:bg-red-700 transition-colors"
230-
>
231-
Add an app
232-
</a>
227+
<div className="flex flex-col sm:flex-row gap-3 w-full lg:w-auto">
228+
<a
229+
href="https://ondemand.connectci.org/appverse-contributor-documentation#8-support"
230+
target="_blank"
231+
rel="noopener noreferrer"
232+
className="w-full sm:w-auto text-center lg:flex-shrink-0 py-3 px-6 border-2 border-appverse-red text-appverse-red font-sans font-semibold rounded-appverse hover:bg-appverse-red hover:text-white transition-colors"
233+
>
234+
App Support
235+
</a>
236+
<a
237+
href="/node/add/appverse_app"
238+
className="w-full sm:w-auto text-center lg:flex-shrink-0 py-3 px-6 bg-appverse-red text-white font-sans font-semibold rounded-appverse hover:bg-red-700 transition-colors"
239+
>
240+
Add an app
241+
</a>
242+
</div>
233243
</div>
234244
</div>
235245

0 commit comments

Comments
 (0)