Merge pull request #3943 from SwiftPackageIndex/unpin-xctest-dynamic-overlay

Unpin xctest dynamic overlay

Author: finestructure

Package.resolved

@@ -40,8 +40,6 @@ let package = Package(
         .package(url: "https://github.com/pointfreeco/swift-dependencies", from: "1.8.0"),
         .package(url: "https://github.com/pointfreeco/swift-parsing.git", from: "0.12.0"),
         .package(url: "https://github.com/pointfreeco/swift-snapshot-testing.git", from: "1.11.1"),
-        // sas 2026-01-12: xctest-dynamic-overlay 1.7.0+ are causing hangs on Linux when running tests locally, and fail in CI
-        .package(url: "https://github.com/pointfreeco/xctest-dynamic-overlay.git", exact: "1.6.1"),
         .package(url: "https://github.com/scinfu/SwiftSoup.git", from: "2.3.2"),
         .package(url: "https://github.com/soto-project/soto.git", from: "6.0.0"),
         .package(url: "https://github.com/vapor-community/soto-cognito-authentication.git", from: "4.0.0"),

Package.swift

@@ -46,7 +46,11 @@ extension MetricsSystemClient: DependencyKey {
 
 extension MetricsSystemClient: TestDependencyKey {
     static var testValue: Self {
-        .init(prometheus: { unimplemented("testValue"); return .init() })
+        // 2026-01-28, sas: Normally, this should be
+        //   .init(prometheus: { unimplemented("testValue"); return .init() })
+        // However, this is currently causing an issue on Linux.
+        // https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/issues/3942
+        .init(prometheus: { .init() })
     }
 }
 

Sources/App/Core/Dependencies/MetricsSystemClient.swift

@@ -180,7 +180,7 @@ struct QueryPerformanceTests {
                   JOIN versions v ON v.package_id = p.id
                 WHERE v.reference ->> 'branch' = r.default_branch
                 """)
-            try await assertQueryPerformance(query, expectedCost: 200_000, variation: 5000)
+            try await assertQueryPerformance(query, expectedCost: 210_000, variation: 5000)
         }
     }
 

Tests/AppTests/QueryPerformanceTests.swift

@@ -42,6 +42,7 @@ extension AllTests.ReAnalyzeVersionsTests {
                 """
             }
             $0.httpClient.mastodonPost = { @Sendable _ in }
+            $0.logger = .noop
         } operation: {
             try await withSPIApp { app in
                 // setup
@@ -215,6 +216,7 @@ extension AllTests.ReAnalyzeVersionsTests {
                 }
                 return ""
             }
+            $0.logger = .noop
         } operation: {
             try await withSPIApp { app in
                 let pkg = try await savePackage(on: app.db,