fix: hotcue comments are utf-16be, regression from mixxxdj#13293

Fixes mixxxdj#14789

Author: Swiftb0y

src/library/rekordbox/rekordboxfeature.cpp

@@ -260,6 +260,11 @@ QString toUnicode(const std::string& toConvert) {
             ->toUnicode(toConvert.data(), static_cast<int>(toConvert.length()));
 }
 
+QString convertComment(const std::string& toConvert) {
+    int length = static_cast<int>(toConvert.length()) - 2; // strip off trailing nullbyte
+    return QTextCodec::codecForName("UTF-16BE")->toUnicode(toConvert.data(), length);
+}
+
 // Functions getText and parseDeviceDB are roughly based on the following Java file:
 // https://github.com/Deep-Symmetry/crate-digger/commit/f09fa9fc097a2a428c43245ddd542ac1370c1adc
 // getText is needed because the strings in the PDB file "have a variety of obscure representations".
@@ -997,7 +1002,7 @@ void readAnalyze(TrackPointer track,
                         memory_cue_loop_t memoryCue;
                         memoryCue.startPosition = position;
                         memoryCue.endPosition = mixxx::audio::kInvalidFramePos;
-                        memoryCue.comment = toUnicode(cueExtendedEntry->comment());
+                        memoryCue.comment = convertComment(cueExtendedEntry->comment());
                         memoryCue.color = colorFromID(static_cast<int>(
                                 cueExtendedEntry->color_id()));
                         memoryCuesAndLoops << memoryCue;
@@ -1016,7 +1021,7 @@ void readAnalyze(TrackPointer track,
                         loop.startPosition = position;
                         loop.endPosition = mixxx::audio::FramePos(
                                 sampleRateKhz * static_cast<double>(endTime));
-                        loop.comment = toUnicode(cueExtendedEntry->comment());
+                        loop.comment = convertComment(cueExtendedEntry->comment());
                         loop.color = colorFromID(static_cast<int>(cueExtendedEntry->color_id()));
                         memoryCuesAndLoops << loop;
                     } break;
@@ -1031,14 +1036,14 @@ void readAnalyze(TrackPointer track,
                             position,
                             mixxx::audio::kInvalidFramePos,
                             hotCueIndex,
-                            toUnicode(cueExtendedEntry->comment()),
+                            convertComment(cueExtendedEntry->comment()),
                             mixxx::RgbColor(qRgb(
                                     static_cast<int>(
                                             cueExtendedEntry->color_red()),
                                     static_cast<int>(
                                             cueExtendedEntry->color_green()),
                                     static_cast<int>(cueExtendedEntry
-                                                             ->color_blue()))));
+                                                    ->color_blue()))));
                 } break;
                 }
             }