Skip to content

Commit c826826

Browse files
committed
update llm review config
1 parent a9d7bec commit c826826

2 files changed

Lines changed: 23 additions & 23 deletions

File tree

.github/workflows/pr-review.yaml

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ jobs:
2525
SERVICE_ACCOUNT_NAME: ${{ secrets.SERVICE_ACCOUNT_NAME}}
2626
SERVICE_ACCOUNT_PASSWORD: ${{ secrets.SERVICE_ACCOUNT_PASSWORD}}
2727
run: |
28-
export SDSC_VLLM_TOKEN=$(curl -X POST https://authentik-server-runai-codev-llm.inference.compute.datascience.ch/application/o/token/ \
28+
export SDSC_VLLM_TOKEN=$(curl -X POST https://authentik-server-runai-sharedllm-ralf.inference.compute.datascience.ch/application/o/token/ \
2929
-H "Content-Type: application/x-www-form-urlencoded" \
30-
-d "grant_type=client_credentials&client_id=09BroBvREXFSYXBTkwse0PlOF5w1rmrk&username=$SERVICE_ACCOUNT_NAME&password=$SERVICE_ACCOUNT_PASSWORD"\
30+
-d "grant_type=client_credentials&client_id=P8dW2vrNPDa8d43qd4BK49eEDYJFtvYk&username=$SERVICE_ACCOUNT_NAME&password=$SERVICE_ACCOUNT_PASSWORD"\
3131
|jq '.access_token' | tr -d '"')
3232
echo "SDSC_VLLM_TOKEN=$SDSC_VLLM_TOKEN" >> "$GITHUB_ENV"
3333
@@ -42,28 +42,29 @@ jobs:
4242
config__custom_model_max_tokens: "32000"
4343
config__ai_timeout: "1800"
4444
openai__extra_body: '{"chat_template_kwargs":{"enable_thinking":false}}'
45-
OPENAI__API_BASE: "https://vllm-gateway-runai-codev-llm.inference.compute.datascience.ch/v1"
45+
OPENAI__API_BASE: "https://vllm-gateway-runai-sharedllm-ralf.inference.compute.datascience.ch/v1"
4646
config__verbosity_level: "2"
4747
github_action_config__auto_review: "true"
4848
github_action_config__auto_describe: "true"
4949
github_action_config__auto_improve: "true"
50-
- name: AI-Review Step
51-
uses: Nikita-Filonov/ai-review@v0.51.0
52-
with:
53-
review-command: run-inline
54-
env:
55-
# --- LLM configuration ---
56-
LLM__PROVIDER: "OPENAI"
57-
LLM__META__MODEL: "Qwen/Qwen3-Coder-30B-A3B-Instruct-FP8"
58-
LLM__META__MAX_TOKENS: "16000"
59-
LLM__HTTP_CLIENT__API_URL: "https://vllm-gateway-runai-codev-llm.inference.compute.datascience.ch/v1"
60-
LLM__HTTP_CLIENT__API_TOKEN: ${{ env.SDSC_VLLM_TOKEN }}
50+
# note: this is a bit too chatty, with lots of comments like "X was changed, please make sure this is what you want"
51+
# - name: AI-Review Step
52+
# uses: Nikita-Filonov/ai-review@v0.51.0
53+
# with:
54+
# review-command: run-inline
55+
# env:
56+
# # --- LLM configuration ---
57+
# LLM__PROVIDER: "OPENAI"
58+
# LLM__META__MODEL: "Qwen/Qwen3-Coder-30B-A3B-Instruct-FP8"
59+
# LLM__META__MAX_TOKENS: "16000"
60+
# LLM__HTTP_CLIENT__API_URL: "https://vllm-gateway-runai-sharedllm-ralf.inference.compute.datascience.ch/v1"
61+
# LLM__HTTP_CLIENT__API_TOKEN: ${{ env.SDSC_VLLM_TOKEN }}
6162

62-
# --- GitHub integration ---
63-
VCS__PROVIDER: "GITHUB"
64-
VCS__PIPELINE__OWNER: ${{ github.repository_owner }}
65-
VCS__PIPELINE__REPO: ${{ github.event.repository.name }}
66-
VCS__PIPELINE__PULL_NUMBER: ${{ github.event.number}}
67-
VCS__HTTP_CLIENT__API_URL: "https://api.github.com"
68-
VCS__HTTP_CLIENT__API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
69-
REVIEW__IGNORE_CHANGES: '["Cargo.lock"]'
63+
# # --- GitHub integration ---
64+
# VCS__PROVIDER: "GITHUB"
65+
# VCS__PIPELINE__OWNER: ${{ github.repository_owner }}
66+
# VCS__PIPELINE__REPO: ${{ github.event.repository.name }}
67+
# VCS__PIPELINE__PULL_NUMBER: ${{ github.event.number}}
68+
# VCS__HTTP_CLIENT__API_URL: "https://api.github.com"
69+
# VCS__HTTP_CLIENT__API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
70+
# REVIEW__IGNORE_CHANGES: '["Cargo.lock"]'

coman/src/cscs/api_client/client.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,6 @@ mod tests {
331331
..Default::default()
332332
}
333333
],
334-
..Default::default()
335334
}),
336335
Result<GetSystemsResponse>
337336
));

0 commit comments

Comments
 (0)