Skip to content

Commit 5d5ad44

Browse files
committed
address review
1 parent d250ac4 commit 5d5ad44

3 files changed

Lines changed: 2 additions & 12 deletions

File tree

deploy/csi-rclone/templates/_certificates-init-container.tpl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
{{- define "csiRcloneCertificates.initContainer" -}}
22
{{- $customCAsEnabled := .Values.csiNodepluginRclone.certificates.customCAs -}}
3-
{{- $customCAsForMountsEnabled := .Values.csiNodepluginRclone.certificates.customCAsForDataConnectorMounts -}}
43
- name: init-certificates
54
image: "{{ .Values.csiNodepluginRclone.certificates.image.repository }}:{{ .Values.csiNodepluginRclone.certificates.image.tag }}"
65
volumeMounts:
76
- name: etc-ssl-certs
87
mountPath: /etc/ssl/certs/
9-
{{- if or $customCAsEnabled $customCAsForMountsEnabled }}
8+
{{- if $customCAsEnabled }}
109
- name: custom-ca-certs
1110
mountPath: /usr/local/share/ca-certificates
1211
readOnly: true
Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
{{- define "csiRcloneCertificatesForMounts.volumes" -}}
22
{{- $customCAsEnabled := .Values.csiNodepluginRclone.certificates.customCAs -}}
3-
{{- $customCAsForMountsEnabled := .Values.csiNodepluginRclone.certificates.customCAsForDataConnectorMounts -}}
43
- name: etc-ssl-certs
54
emptyDir:
65
medium: "Memory"
7-
{{- if or $customCAsEnabled $customCAsForMountsEnabled }}
6+
{{- if $customCAsEnabled }}
87
- name: custom-ca-certs
98
projected:
109
defaultMode: 0444
@@ -15,11 +14,5 @@
1514
name: {{ $customCA.secret }}
1615
{{- end -}}
1716
{{- end -}}
18-
{{- if $customCAsForMountsEnabled }}
19-
{{- range $customCA := .Values.csiNodepluginRclone.certificates.customCAsForDataConnectorMounts }}
20-
- secret:
21-
name: {{ $customCA.secret }}
22-
{{- end -}}
23-
{{- end -}}
2417
{{- end -}}
2518
{{- end -}}

deploy/csi-rclone/values.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,6 @@ csiNodepluginRclone:
117117
tag: "0.0.2"
118118
customCAs: []
119119
# - secret:
120-
customCAsForDataConnectorMounts: []
121-
# - secret:
122120
serviceAccount:
123121
annotations: {}
124122
nodeSelector: {}

0 commit comments

Comments
 (0)