Skip to content

Commit 070cf06

Browse files
authored
chore: evaluate test_mode as a string (#186)
[Action](https://github.com/SwissDataScienceCenter/renku-frontend-buildpacks/actions/runs/21180553109/job/60927437341#step:6:99) to update the versions failed because the `test_mode` was not properly evaluated
1 parent c3ee255 commit 070cf06

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

.github/workflows/update-versions.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ jobs:
9595
platforms: linux/amd64,linux/arm64
9696
target: run
9797
push: true
98-
tags: ghcr.io/${{ needs.validate-tag.outputs.repo_lower }}/run-image:${{ github.event.inputs.version }}${{ (github.event.inputs.test_mode && '-test') || '' }}
98+
tags: ghcr.io/${{ needs.validate-tag.outputs.repo_lower }}/run-image:${{ github.event.inputs.version }}${{ github.event.inputs.test_mode == 'true' && '-test' || '' }}
9999
labels: |
100100
io.buildpacks.base.distro.name=ubuntu
101101
io.buildpacks.base.distro.version=24.04
@@ -111,7 +111,7 @@ jobs:
111111
build-args: base_image=nvcr.io/nvidia/cuda-dl-base:25.10-cuda13.0-devel-ubuntu24.04
112112
target: run
113113
push: true
114-
tags: ghcr.io/${{ needs.validate-tag.outputs.repo_lower }}/cuda-run-image:${{ github.event.inputs.version }}${{ (github.event.inputs.test_mode && '-test') || '' }}
114+
tags: ghcr.io/${{ needs.validate-tag.outputs.repo_lower }}/cuda-run-image:${{ github.event.inputs.version }}${{ github.event.inputs.test_mode == 'true' && '-test' || '' }}
115115
labels: |
116116
io.buildpacks.base.distro.name=ubuntu
117117
io.buildpacks.base.distro.version=24.04
@@ -127,7 +127,7 @@ jobs:
127127
build-args: base_image=nvcr.io/nvidia/cuda-dl-base:25.10-cuda13.0-devel-ubuntu24.04
128128
target: build
129129
push: true
130-
tags: ghcr.io/${{ needs.validate-tag.outputs.repo_lower }}/cuda-build-image:${{ github.event.inputs.version }}${{ (github.event.inputs.test_mode && '-test') || '' }}
130+
tags: ghcr.io/${{ needs.validate-tag.outputs.repo_lower }}/cuda-build-image:${{ github.event.inputs.version }}${{ github.event.inputs.test_mode == 'true' && '-test' || '' }}
131131
labels: |
132132
io.buildpacks.base.distro.name=ubuntu
133133
io.buildpacks.base.distro.version=24.04
@@ -150,13 +150,13 @@ jobs:
150150
token: ${{ secrets.GITHUB_TOKEN }}
151151

152152
- name: Update buildpack.toml versions
153-
run: make update-buildpack-versions RELEASE_VERSION=${{ github.event.inputs.version }}${{ (github.event.inputs.test_mode && '-test') || '' }}
153+
run: make update-buildpack-versions RELEASE_VERSION=${{ github.event.inputs.version }}${{ (github.event.inputs.test_mode == 'true' && '-test') || '' }}
154154

155155
- name: Update builder.toml
156-
run: make update-builder-versions RELEASE_VERSION=${{ github.event.inputs.version }}${{ (github.event.inputs.test_mode && '-test') || '' }}
156+
run: make update-builder-versions RELEASE_VERSION=${{ github.event.inputs.version }}${{ (github.event.inputs.test_mode == 'true' && '-test') || '' }}
157157

158158
- name: update build-image action
159-
run: make update-action-versions RELEASE_VERSION=${{ github.event.inputs.version }}${{ (github.event.inputs.test_mode && '-test') || '' }}
159+
run: make update-action-versions RELEASE_VERSION=${{ github.event.inputs.version }}${{ (github.event.inputs.test_mode == 'true' && '-test') || '' }}
160160

161161
- name: Create Pull Request
162162
uses: peter-evans/create-pull-request@v7
@@ -174,9 +174,9 @@ jobs:
174174
175175
**Please review and merge to complete the release process.**
176176
branch: update-versions-${{ github.event.inputs.version }}
177-
base: ${{ (github.event.inputs.test_mode && format('test-release/{0}', github.ref_name)) || 'main' }}
177+
base: ${{ (github.event.inputs.test_mode == 'true' && format('test-release/{0}', github.ref_name)) || 'main' }}
178178
delete-branch: true
179-
labels: ${{ github.event.inputs.test_mode && 'test-release' || 'release' }}
179+
labels: ${{ github.event.inputs.test_mode == 'true' && 'test-release' || 'release' }}
180180

181181
move-tag:
182182
if: github.event_name == 'pull_request' && github.event.pull_request.merged == true && startsWith(github.head_ref, 'update-versions-')

0 commit comments

Comments
 (0)