Skip to content

Commit e04c33c

Browse files
authored
fix: ux improvement - jupyter kernels (#38)
* fix(ux): remove 'custom_env' kernel installation * fix(ux): rename 'mutable_env' to 'Python3'
1 parent 1d5d5b5 commit e04c33c

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

  • buildpacks
    • kernel-installer/bin
    • python-dependency-manager/bin

buildpacks/kernel-installer/bin/build

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,8 @@ python_version=python$(python --version|cut -d' ' -f2)
1717
site_packages="$kernel_layer_dir/lib/${python_version%.*}/site-packages"
1818
export PYTHONPATH="$site_packages:$PYTHONPATH"
1919
export JUPYTER_PATH="${kernel_layer_dir}/share/jupyter/"
20-
python -m ipykernel install --prefix="${kernel_layer_dir}" --name=custom_env
2120
"${kernel_layer_dir}"/bin/jupyter-kernelspec remove -f python3 || echo "Could not find python3 kernelpsec to remove"
2221

23-
printf '%s' "${JUPYTER_PATH}"> "${env_dir}"/JUPYTER_PATH
2422
printf ':'> "${env_dir}"/PYTHONPATH.delim
2523
printf '%s' "${site_packages}"> "${env_dir}"/PYTHONPATH.prepend
2624

buildpacks/python-dependency-manager/bin/build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ python -m venv --system-site-packages \${RENKU_MOUNT_DIR}/.venv
1212
printf 'source \${RENKU_MOUNT_DIR}/.venv/bin/activate' >> \${HOME}/.bashrc
1313
source \${RENKU_MOUNT_DIR}/.venv/bin/activate
1414
if python -c "import ipykernel" >/dev/null 2>&1;then
15-
python -m ipykernel install --user --name mutable_env
15+
python -m ipykernel install --user --name Python3
1616
fi
1717
EOL
1818

0 commit comments

Comments
 (0)