address comment

Author: Panaetius

cmd/gateway/main.go

@@ -127,15 +127,15 @@ func main() {
 	// Initialize login server
 	loginOptions := []login.LoginServerOption{login.WithConfig(gwConfig.Login), login.WithSessionStore(sessionStore), login.WithTokenStore(tokenStore)}
 
-	if gwConfig.Posthog.Enabled {
-		metricsClient, err := metrics.NewPosthogClient(gwConfig.Posthog.ApiKey, gwConfig.Posthog.Host, gwConfig.Posthog.Environment)
-		if err != nil {
-			slog.Error("posthog client initializtion failed", "error", err)
-			os.Exit(1)
-		}
-		loginOptions = append(loginOptions, login.WithMetricsClient(metricsClient))
+	metricsClient, err := metrics.NewPosthogClient(gwConfig.Posthog)
+	if err != nil {
+		slog.Error("posthog client initializtion failed", "error", err)
+		os.Exit(1)
+	}
+	if metricsClient != nil {
 		defer metricsClient.Close()
 	}
+	loginOptions = append(loginOptions, login.WithMetricsClient(metricsClient))
 	loginServer, err := login.NewLoginServer(loginOptions...)
 	if err != nil {
 		slog.Error("login handlers initialization failed", "error", err)

internal/config/other.go

@@ -32,7 +32,7 @@ type RateLimits struct {
 
 type PosthogConfig struct {
 	Enabled     bool
-	ApiKey      string
+	ApiKey      RedactedString
 	Host        string
 	Environment string
 }

internal/metrics/posthog.go

@@ -4,6 +4,7 @@ import (
 	"crypto/md5"
 	"encoding/hex"
 
+	"github.com/SwissDataScienceCenter/renku-gateway/internal/config"
 	"github.com/posthog/posthog-go"
 )
 
@@ -24,12 +25,12 @@ func (p *PosthogMetricsClient) Close() {
 	p.posthogClient.Close()
 }
 
-func NewPosthogClient(apiKey string, host string, environment string) (*PosthogMetricsClient, error) {
+func NewPosthogClient(c config.PosthogConfig) (*PosthogMetricsClient, error) {
 	client, err := posthog.NewWithConfig(
-		apiKey,
+		string(c.ApiKey),
 		posthog.Config{
-			Endpoint:               host,
-			DefaultEventProperties: posthog.Properties{"environment": environment},
+			Endpoint:               c.Host,
+			DefaultEventProperties: posthog.Properties{"environment": c.Environment},
 		},
 	)
 	if err != nil {