Skip to content

Commit fcefdca

Browse files
committed
Merge branch 'feature/integration-improvements' into andrea/redesign-integration-page
# Conflicts: # client/src/features/connectedServices/ConnectedServicesPage.tsx # client/src/features/rootV2/RootV2.tsx # tests/cypress/e2e/connectedServicesV2.spec.ts
2 parents 286b9f8 + f58cf05 commit fcefdca

28 files changed

Lines changed: 169 additions & 238 deletions

client/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "renku-ui",
3-
"version": "4.21.0",
3+
"version": "4.22.0",
44
"private": true,
55
"scripts": {
66
"start": "NODE_OPTIONS='--import ./instrument.server.mjs' react-router dev --port 3000",

client/src/CatchallApp.tsx

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import { ReactNode } from "react";
2121
import { Route, Routes } from "react-router";
2222

2323
import LazyAdminPage from "./features/admin/LazyAdminPage";
24-
import LazyAnonymousHome from "./features/landing/LazyAnonymousHome";
2524
import LegacyDatasetAddToProject from "./features/legacy/LegacyDatasetAddToProject";
2625
import LegacyDatasets from "./features/legacy/LegacyDatasets";
2726
import LegacyProjectView from "./features/legacy/LegacyProjectView";
@@ -39,18 +38,6 @@ export default function CatchallApp() {
3938
const { data: user } = useGetUserQueryState();
4039
return (
4140
<Routes>
42-
<Route
43-
index
44-
element={
45-
user?.isLoggedIn ? (
46-
<LazyRootV2 />
47-
) : (
48-
<div className="w-100">
49-
<LazyAnonymousHome />
50-
</div>
51-
)
52-
}
53-
/>
5441
<Route path="/projects/*" element={<LegacyProjectView />} />
5542
<Route
5643
path="/datasets/:identifier/add"

client/src/components/progress/Progress.css

Lines changed: 0 additions & 158 deletions
This file was deleted.
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
// TODO: use bootstrap margin classes
2+
.progressBoxSmall {
3+
max-width: 500px;
4+
margin: auto;
5+
6+
&Steps {
7+
padding-top: 110px;
8+
}
9+
}
10+
11+
.progressBox {
12+
width: 100%;
13+
padding: 40px 25px 20px 25px;
14+
15+
& h2 {
16+
color: var(--bs-dark);
17+
font-weight: bold;
18+
font-size: 20px;
19+
}
20+
21+
& p {
22+
color: var(--bs-dark);
23+
font-weight: normal;
24+
font-size: 16px;
25+
}
26+
27+
&_dark {
28+
background-color: var(--bs-rk-dark-bg);
29+
}
30+
}

client/src/components/progress/ProgressSteps.tsx

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* Copyright 2022 - Swiss Data Science Center (SDSC)
2+
* Copyright 2026 - Swiss Data Science Center (SDSC)
33
* A partnership between École Polytechnique Fédérale de Lausanne (EPFL) and
44
* Eidgenössische Technische Hochschule Zürich (ETHZ).
55
*
@@ -16,6 +16,7 @@
1616
* limitations under the License.
1717
*/
1818

19+
import cx from "classnames";
1920
import {
2021
CheckCircleFill,
2122
SlashCircle,
@@ -24,7 +25,7 @@ import {
2425

2526
import { Loader } from "../Loader";
2627

27-
import "./Progress.css";
28+
import styles from "./ProgressBox.module.scss";
2829

2930
/**
3031
* renku-ui
@@ -74,31 +75,27 @@ interface ProgressStepsIndicatorProps {
7475
moreOptions?: React.ReactNode;
7576
}
7677

77-
/**
78-
* Project Visibility functional component
79-
* @param {ProgressIndicatorProps} props - progress indicator options
80-
*/
81-
const ProgressStepsIndicator = ({
78+
export default function ProgressStepsIndicator({
8279
style = ProgressStyle.Dark,
8380
title,
8481
description,
8582
status,
8683
moreOptions,
87-
}: ProgressStepsIndicatorProps) => {
84+
}: ProgressStepsIndicatorProps) {
8885
const content = status.map((s) => (
8986
<ProgressStep key={`step-${s.id}`} step={s} />
9087
));
9188
return (
92-
<div className={`progress-box progress-box--${style}`}>
93-
<h2 className="progress-title">{title}</h2>
89+
<div className={cx(styles.progressBox, styles[`progressBox_${style}`])}>
90+
<h2>{title}</h2>
9491
<p className="pb-2">{description}</p>
95-
<div className="mt-3 details-progress-box">
92+
<div className="mt-3">
9693
{content}
9794
{moreOptions}
9895
</div>
9996
</div>
10097
);
101-
};
98+
}
10299

103100
interface progressStepProps {
104101
step: StepsProgressBar;
@@ -148,7 +145,9 @@ function ProgressStep({ step }: progressStepProps) {
148145
break;
149146
}
150147

151-
return <div className="d-flex gap-2 mt-2 align-items-center">{content}</div>;
148+
return (
149+
<div className={cx("d-flex", "gap-2", "mt-2", "align-items-center")}>
150+
{content}
151+
</div>
152+
);
152153
}
153-
154-
export default ProgressStepsIndicator;

client/src/features/ProjectPageV2/ProjectPageContent/Settings/ProjectDelete.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export default function ProjectPageDelete({ project }: ProjectDeleteProps) {
4242

4343
useEffect(() => {
4444
if (result.isSuccess) {
45-
navigate(ABSOLUTE_ROUTES.v2.root);
45+
navigate(ABSOLUTE_ROUTES.v2.index);
4646
renkuToastSuccess({
4747
textHeader: NOTIFICATION_TOPICS.PROJECT_DELETED,
4848
textBody: (

client/src/features/dashboardV2/DashboardV2Sessions.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,14 +127,14 @@ function DashboardSession({ session }: DashboardSessionProps) {
127127
? generatePath(ABSOLUTE_ROUTES.v2.projects.showById, {
128128
id: projectId,
129129
})
130-
: ABSOLUTE_ROUTES.v2.root;
130+
: ABSOLUTE_ROUTES.v2.index;
131131
const showSessionUrl = project
132132
? generatePath(ABSOLUTE_ROUTES.v2.projects.show.sessions.show, {
133133
namespace: project.namespace,
134134
slug: project.slug,
135135
session: session.name,
136136
})
137-
: ABSOLUTE_ROUTES.v2.root;
137+
: ABSOLUTE_ROUTES.v2.index;
138138

139139
const sessionStyles = getSessionStatusStyles(session);
140140
const state = session.status.state;

client/src/features/groupsV2/settings/GroupSettingsMetadata.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ function GroupDeleteConfirmation({
8888
renkuToastSuccess({
8989
textHeader: `Group ${group.name} has been successfully deleted.`,
9090
});
91-
navigate(generatePath(ABSOLUTE_ROUTES.v2.root));
91+
navigate(generatePath(ABSOLUTE_ROUTES.v2.index));
9292
}
9393
}, [
9494
group.name,

client/src/features/landing/hooks/useCustomHomePageProjectUrl.hook.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ export function useCustomHomePageProjectUrl(): string {
2727
const { params } = useContext(AppContext);
2828
const homePage = params?.["HOMEPAGE"] ?? DEFAULT_APP_PARAMS.HOMEPAGE;
2929
if (!homePage || !homePage.projectPath)
30-
return generatePath(ABSOLUTE_ROUTES.v2.root);
30+
return generatePath(ABSOLUTE_ROUTES.v2.index);
3131
const [namespace, slug] = homePage.projectPath.split("/");
32-
if (!namespace || !slug) return generatePath(ABSOLUTE_ROUTES.v2.root);
32+
if (!namespace || !slug) return generatePath(ABSOLUTE_ROUTES.v2.index);
3333
return generatePath(ABSOLUTE_ROUTES.v2.projects.show.root, {
3434
namespace,
3535
slug,

0 commit comments

Comments
 (0)