Skip to content

Commit 8a7ca36

Browse files
committed
Merge remote-tracking branch 'origin/release-2.16.0' into feat/private-repository-build
2 parents cc8ee78 + 9946e0c commit 8a7ca36

8 files changed

Lines changed: 127 additions & 155 deletions

File tree

cypress-tests/cypress/e2e/v2/dataConnectors.cy.ts

Lines changed: 43 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -111,17 +111,16 @@ describe("Data Connectors", () => {
111111
visitCurrentProject();
112112
cy.getDataCy("project-namespace-link").click();
113113

114+
// Open the data connector view and delete from the menu
114115
cy.getDataCy("data-connector-box")
115116
.find(`[data-cy=data-connector-name]`)
116117
.contains(dataConnectorName)
117-
.click();
118-
119-
// Open the dropdown menu and click delete
120-
cy.getDataCy("data-connector-menu-dropdown")
121118
.should("be.visible")
122-
.scrollIntoView()
123119
.click();
124-
cy.getDataCy("data-connector-delete").should("be.visible").click();
120+
cy.getDataCy("data-connector-view").within(() => {
121+
cy.getDataCy("data-connector-menu-dropdown").click();
122+
cy.getDataCy("data-connector-delete").click();
123+
});
125124

126125
// Confirm deletion by typing the slug
127126
cy.getDataCy("delete-confirmation-input").type(dataConnectorName);
@@ -171,11 +170,10 @@ describe("Data Connectors", () => {
171170
.click();
172171

173172
// Delete the data connector
174-
cy.getDataCy("data-connector-menu-dropdown")
175-
.should("be.visible")
176-
.scrollIntoView()
177-
.click();
178-
cy.getDataCy("data-connector-delete").should("be.visible").click();
173+
cy.getDataCy("data-connector-view").within(() => {
174+
cy.getDataCy("data-connector-menu-dropdown").click();
175+
cy.getDataCy("data-connector-delete").click();
176+
});
179177

180178
// Confirm deletion by typing the slug
181179
cy.getDataCy("delete-confirmation-input").type(dataConnectorName);
@@ -228,11 +226,10 @@ describe("Data Connectors", () => {
228226
.click();
229227

230228
// Delete the data connector
231-
cy.getDataCy("data-connector-menu-dropdown")
232-
.should("be.visible")
233-
.scrollIntoView()
234-
.click();
235-
cy.getDataCy("data-connector-delete").should("be.visible").click();
229+
cy.getDataCy("data-connector-view").within(() => {
230+
cy.getDataCy("data-connector-menu-dropdown").click();
231+
cy.getDataCy("data-connector-delete").click();
232+
});
236233

237234
// Confirm deletion by typing the slug
238235
cy.getDataCy("delete-confirmation-input").type(dataConnectorName);
@@ -257,7 +254,9 @@ describe("Data Connectors", () => {
257254
.find(`[data-cy=data-connector-name]`)
258255
.contains(dataConnectorName)
259256
.click();
260-
cy.getDataCy("data-connector-edit").click();
257+
cy.getDataCy("data-connector-view").within(() => {
258+
cy.getDataCy("data-connector-edit").click();
259+
});
261260

262261
// Edit the data connector
263262
const newName = `${dataConnectorName} edited`;
@@ -332,13 +331,13 @@ describe("Data Connectors", () => {
332331
.contains(dataConnectorName)
333332
.click();
334333

335-
cy.getDataCy("data-connector-title")
336-
.should("be.visible")
337-
.contains(dataConnectorName);
338-
339-
// Click the dropdown button to open the menu
340-
cy.getDataCy("data-connector-menu-dropdown").should("be.visible").click();
341-
cy.getDataCy("data-connector-unlink").should("be.visible").click();
334+
cy.getDataCy("data-connector-view").within(() => {
335+
cy.getDataCy("data-connector-title")
336+
.should("be.visible")
337+
.contains(dataConnectorName);
338+
cy.getDataCy("data-connector-menu-dropdown").click();
339+
cy.getDataCy("data-connector-unlink").should("be.visible").click();
340+
});
342341

343342
cy.getDataCy("delete-data-connector-modal-button").click();
344343

@@ -390,13 +389,14 @@ describe("Data Connectors", () => {
390389
.contains(dataConnectorName)
391390
.click();
392391

393-
cy.getDataCy("data-connector-title")
394-
.should("be.visible")
395-
.contains(dataConnectorName);
396-
397392
// Unlink the data connector from the main project
398-
cy.getDataCy("data-connector-menu-dropdown").should("be.visible").click();
399-
cy.getDataCy("data-connector-unlink").should("be.visible").click();
393+
cy.getDataCy("data-connector-view").within(() => {
394+
cy.getDataCy("data-connector-title")
395+
.should("be.visible")
396+
.contains(dataConnectorName);
397+
cy.getDataCy("data-connector-menu-dropdown").click();
398+
cy.getDataCy("data-connector-unlink").should("be.visible").click();
399+
});
400400
cy.getDataCy("delete-data-connector-modal-button").click();
401401

402402
// Verify the data connector is no longer linked to the main project
@@ -423,12 +423,13 @@ describe("Data Connectors", () => {
423423
.contains(dataConnectorName)
424424
.click();
425425

426-
cy.getDataCy("data-connector-title")
427-
.should("be.visible")
428-
.contains(dataConnectorName);
429-
430426
// Edit the data connector to transfer it to the group
431-
cy.getDataCy("data-connector-edit").click();
427+
cy.getDataCy("data-connector-view").within(() => {
428+
cy.getDataCy("data-connector-title")
429+
.should("be.visible")
430+
.contains(dataConnectorName);
431+
cy.getDataCy("data-connector-edit").click();
432+
});
432433

433434
// Change the owner to the group
434435
cy.getDataCy("data-controller-namespace-input").click();
@@ -487,13 +488,14 @@ describe("Data Connectors", () => {
487488
.contains(dataConnectorName)
488489
.click();
489490

490-
cy.getDataCy("data-connector-title")
491-
.should("be.visible")
492-
.contains(dataConnectorName);
493-
494491
// Unlink the data connector from the project
495-
cy.getDataCy("data-connector-menu-dropdown").should("be.visible").click();
496-
cy.getDataCy("data-connector-unlink").should("be.visible").click();
492+
cy.getDataCy("data-connector-view").within(() => {
493+
cy.getDataCy("data-connector-title")
494+
.should("be.visible")
495+
.contains(dataConnectorName);
496+
cy.getDataCy("data-connector-menu-dropdown").should("be.visible").click();
497+
cy.getDataCy("data-connector-unlink").should("be.visible").click();
498+
});
497499
cy.getDataCy("delete-data-connector-modal-button").click();
498500

499501
// Verify the data connector is no longer linked to the project

docs/package-lock.json

Lines changed: 4 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)