fix(web): keep day event form closed after drag (#1888)

* docs(web): define day drag form lifecycle

* docs(web): plan day drag form lifecycle

* test(web): cover day drag form lifecycle

* fix(web): keep day event form closed after drag

* chore: keep agent planning docs local

* chore: remove unnecessary test

Author: tyler-dane

.gitignore

@@ -39,6 +39,7 @@ node_modules/
 playwright-report/
 test-results/
 blob-report/
+# Local agent-generated plans and specs
 docs/superpowers/
 docs/pr-explainers/
 

packages/web/src/views/Day/interaction/DayInteractionCoordinator.test.tsx

@@ -204,12 +204,10 @@ describe("DayInteractionCoordinator", () => {
     expect(isOpenAtCursor(CursorItem.EventForm)).toBe(false);
   });
 
-  it("reopens the Day event form with the moved event instead of immediately saving", async () => {
+  it("saves a moved event without opening a form", async () => {
     const { dispatch, store } = renderCoordinator();
-    const source = screen.getByTestId("timed-source");
     const child = screen.getByTestId("timed-child");
 
-    openFloatingForm(source);
     fireEvent.pointerDown(child, {
       button: 0,
       clientX: 160,
@@ -229,15 +227,37 @@ describe("DayInteractionCoordinator", () => {
       pointerId: 1,
     });
 
-    expect(
-      dispatch.mock.calls.some(
-        ([action]) => action.type === editEventSlice.actions.request.type,
-      ),
-    ).toBe(false);
+    await waitFor(() => {
+      expect(
+        dispatch.mock.calls.some(
+          ([action]) => action.type === editEventSlice.actions.request.type,
+        ),
+      ).toBe(true);
+    });
+    expect(isOpenAtCursor(CursorItem.EventForm)).toBe(false);
+    expect(store.getState().events.draft.event).toBeNull();
+  });
+
+  it("opens the event form when pointer interaction does not move the event", async () => {
+    const { store } = renderCoordinator();
+    const child = screen.getByTestId("timed-child");
+
+    fireEvent.pointerDown(child, {
+      button: 0,
+      clientX: 160,
+      clientY: 160,
+      isPrimary: true,
+      pointerId: 1,
+    });
+    fireEvent.pointerUp(window, {
+      clientX: 160,
+      clientY: 160,
+      pointerId: 1,
+    });
 
     await waitFor(() => {
       expect(isOpenAtCursor(CursorItem.EventForm)).toBe(true);
-      expect(store.getState().events.draft.event?.startDate).toContain("10:00");
     });
+    expect(store.getState().events.draft.event?._id).toBe(timedEvent._id);
   });
 });

packages/web/src/views/Day/interaction/DayInteractionCoordinator.tsx

@@ -115,12 +115,9 @@ export const DayInteractionCoordinator: FC<Props> = ({
       return;
     }
 
-    if (result.hadFormOpenBeforeInteraction) {
-      openDayCalendarEvent(result.event);
-      return;
-    }
-
+    closeFloatingAtCursor();
     updateEvent({ event: result.event }, true);
+    dispatch(draftSlice.actions.discard(undefined));
   };
 
   runtimeRef.current = {