Merge pull request #556 from aunncodes/craftingdupe

Fix Shift Click Dupe

Author: ItzKatze

type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/gui/inventories/sbmenu/GUICrafting.java

@@ -127,7 +127,12 @@ public void run(InventoryPreClickEvent e, HypixelPlayer p) {
                         finalRecipe.getResult().getItemStack()).amount(amount).build();
 
                 e.setCancelled(true);
-                p.getInventory().setCursorItem(craftedItem);
+                if (isShift) {
+                    player.addAndUpdateItem(craftedItem);
+                }
+                else {
+                    p.getInventory().setCursorItem(craftedItem);
+                }
                 HypixelEventHandler.callCustomEvent(new ItemCraftEvent(player, new SkyBlockItem(craftedItem), finalRecipe));
 
                 SkyBlockItem[] toReplace = finalRecipe.consume(getCurrentRecipeAsItems(inventory));
@@ -140,11 +145,6 @@ public void run(InventoryPreClickEvent e, HypixelPlayer p) {
                                 toReplace[i].getItemStack()).build());
                     }
                 }
-                if (isShift) {
-                    // if is a shift click add updated item to player inventory
-                    e.setCancelled(true);
-                    player.addAndUpdateItem(e.getClickedItem());
-                }
 
                 if (cursorItemType != null && cursorItemType.equals(resultItemType) && !isShift) {
                     e.setCancelled(true);