Resolve issue with file writing

Author: Syasyazman

META-INF/MANIFEST 2.MF

@@ -1,3 +1,2 @@
 Manifest-Version: 1.0
 Main-Class: Duke
-

META-INF/MANIFEST.MF

@@ -44,7 +44,7 @@ test {
 }
 
 application {
-    mainClassName = "seedu.duke.Duke"
+    mainClassName = "Launcher"
 }
 
 shadowJar {

build.gradle

@@ -2,10 +2,7 @@
 
 import java.io.File;
 
-import java.util.ArrayList;
-
 import javafx.application.Application;
-import javafx.application.Platform;
 import javafx.scene.Scene;
 import javafx.scene.control.Label;
 import javafx.stage.Stage;
@@ -16,8 +13,6 @@
 import javafx.scene.layout.VBox;
 import javafx.scene.layout.Region;
 import javafx.scene.image.Image;
-import javafx.scene.image.ImageView;
-import javafx.fxml.FXML;
 
 /**
  * Main class for Duke
@@ -46,31 +41,23 @@ public Duke() {
         this.file = new File("data/duke.txt");
 
         try {
-            if (storage.hasFile()) {
-                this.tasks = new TaskList(storage.loadDataFromFile(this.ui));
-            } else {
-                throw new DukeException("file does not exist");
-            }
-        } catch (DukeException e) {
-            this.ui.showFileLoadingError();
-            this.tasks = new TaskList(new ArrayList<>());
+            this.tasks = new TaskList(storage.loadDataFromFile(this.ui));
+        } catch (Exception e) {
+            ui.showFileLoadingError();
         }
     }
 
+
     public Duke(String filepath) {
         this.storage = new Storage(filepath);
         this.ui = new Ui();
         this.guiui = new GuiUi();
+        this.file = new File(filepath);
 
         try {
-            if (storage.hasFile()) {
-                this.tasks = new TaskList(storage.loadDataFromFile(this.ui));
-            } else {
-                throw new DukeException("file does not exist");
-            }
-        } catch (DukeException e) {
-            this.ui.showFileLoadingError();
-            this.tasks = new TaskList(new ArrayList<>());
+            this.tasks = new TaskList(storage.loadDataFromFile(this.ui));
+        } catch (Exception e) {
+            ui.showFileLoadingError();
         }
     }
 

src/main/java/Duke.java

@@ -8,8 +8,6 @@
 
 import javafx.application.Platform;
 
-import java.util.concurrent.TimeUnit;
-
 /**
  * Controller for MainWindow. Provides the layout for the other controls.
  */

src/main/java/MainWindow.java

@@ -17,24 +17,13 @@
  */
 public class Storage {
     protected File file;
+    protected String filepath;
 
     public Storage(String filepath) {
+        this.filepath = filepath;
         this.file = new File(filepath);
     }
 
-    /**
-     * checks if hard disk file directory exists
-     *
-     * @return whether the hard disk file exists
-     */
-    public boolean hasFile() {
-        String home = System.getProperty("user.home");
-
-        java.nio.file.Path path = java.nio.file.Paths.get(home, "Desktop", "CS2103", "Projects", "iP", "data",
-                "duke.txt");
-        return java.nio.file.Files.exists(path);
-    }
-
     /**
      * Writes task to hard disk file
      *
@@ -43,28 +32,24 @@ public boolean hasFile() {
      */
     public void addTasksToFile(FileWriter writer, List<Task> ls) {
         try {
-            if (writer != null) {
-                for (Task task : ls) {
-                    // get details about task
-                    String item = task.getItem();
-                    String status = task.getStatus();
-                    String taskType = task.getSign();
-
-                    // check task type
-                    if (task instanceof Todo) { // if task is to-do
-                        writer.write(taskType + " / " + status + " / " + item + "\n");
-                    } else if (task instanceof Deadline) { // if task is deadline
-                        Deadline actualTask = (Deadline) task;
-                        writer.write(taskType + " / " +  status + " / " + item + " / " +
-                                actualTask.getDeadline() + "\n");
-                    } else { // if task is event
-                        Event actualTask = (Event) task;
-                        writer.write(taskType + " / " + status + " / " + item + " / " +
-                                actualTask.getTime() + "\n");
-                    }
+            for (Task task : ls) {
+                // get details about task
+                String item = task.getItem();
+                String status = task.getStatus();
+                String taskType = task.getSign();
+
+                // check task type
+                if (task instanceof Todo) { // if task is to-do
+                    writer.write(taskType + " / " + status + " / " + item + "\n");
+                } else if (task instanceof Deadline) { // if task is deadline
+                    Deadline actualTask = (Deadline) task;
+                    writer.write(taskType + " / " +  status + " / " + item + " / " +
+                            actualTask.getDeadline() + "\n");
+                } else { // if task is event
+                    Event actualTask = (Event) task;
+                    writer.write(taskType + " / " + status + " / " + item + " / " +
+                            actualTask.getTime() + "\n");
                 }
-            } else {
-                throw new IOException("invalid writer");
             }
         } catch (IOException e) {
             System.out.println("An error occurred: invalid writer");
@@ -82,10 +67,15 @@ public List<Task> loadDataFromFile(Ui ui) {
         List<Task> ls = new ArrayList<>();
 
         try {
-            if (this.file != null) {
+            File directory = new File("data/");
+            if (!directory.exists()) {
+                directory.mkdir();
+            }
+
+            if (this.file.exists()) {
                 sc = new Scanner(this.file);
 
-                while(sc.hasNextLine()) {
+                while (sc.hasNextLine()) {
                     String line = sc.nextLine();
 
                     String[] inputArr = line.split(" / ", 3);
@@ -97,10 +87,14 @@ public List<Task> loadDataFromFile(Ui ui) {
                     ls.add(newTask);
                 }
             } else {
-                throw new FileNotFoundException("File not found");
+                try {
+                    this.file.createNewFile();
+                } catch (IOException e) {
+                    ui.showCannotCreateFileError();
+                }
             }
         } catch (FileNotFoundException e) {
-            System.out.println("File not found!!");
+            ui.showFileNotFoundError();
         }
 
         return ls;
@@ -177,7 +171,7 @@ public Task createTask(String taskType, String status, String restOfTaskInfo, Ui
      * @throws IOException
      */
     public void writeToFile(TaskList tasks) throws IOException {
-        FileWriter writer = new FileWriter(file);
+        FileWriter writer = new FileWriter(this.file);
         this.addTasksToFile(writer, tasks.getls());
         writer.close();
     }

src/main/java/duke/Storage.java

@@ -1,8 +1,6 @@
 package duke;
 
-import java.time.format.DateTimeFormatter;
 import java.util.List;
-import java.time.LocalDate;
 
 /**
  * Handles operations regarding user task list

src/main/java/duke/TaskList.java

@@ -274,4 +274,16 @@ public void showInvalidTaskTypeEditError() {
         System.out.println("Im so sorry but I only edit dates of deadlines or events !\n");
         System.out.println("??????????????????????????????????????????????????????????????\n");
     }
+
+    public void showFileNotFoundError() {
+        System.out.println("??????????????????????????????????????????????????????????????\n");
+        System.out.println("File not found ...\n");
+        System.out.println("??????????????????????????????????????????????????????????????\n");
+    }
+
+    public void showCannotCreateFileError() {
+        System.out.println("??????????????????????????????????????????????????????????????\n");
+        System.out.println("Cannot create file ...\n");
+        System.out.println("??????????????????????????????????????????????????????????????\n");
+    }
 }