Merge pull request #20 from Rafikooo/fix/serializer-propagation

Fix serializer not propagated to decorated normalizer

Author: mpysiak

config/services.xml

@@ -148,7 +148,7 @@
             decorates="api_platform.serializer.normalizer.item"
             parent="api_platform.serializer.normalizer.item"
         >
-            <argument type="service" id=".inner" />
+            <argument key="$decorated" type="service" id=".inner" />
         </service>
 
         <service id="sylius_import_export.twig.component.import_resource" class="Sylius\ImportExport\Twig\Component\ImportResourceFormComponent">

phpunit.xml.dist

@@ -7,6 +7,9 @@
     bootstrap="vendor/sylius/test-application/config/bootstrap.php"
 >
     <testsuites>
+        <testsuite name="unit">
+            <directory>tests/Unit</directory>
+        </testsuite>
         <testsuite name="functional">
             <directory>tests/Functional</directory>
         </testsuite>

src/Serializer/ExportAwareItemNormalizer.php

@@ -26,6 +26,8 @@
 use Symfony\Component\PropertyAccess\PropertyAccessorInterface;
 use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactoryInterface;
 use Symfony\Component\Serializer\NameConverter\NameConverterInterface;
+use Symfony\Component\Serializer\SerializerAwareInterface;
+use Symfony\Component\Serializer\SerializerInterface;
 
 /**
  * @see ItemNormalizer
@@ -49,7 +51,7 @@ public function __construct(
         ?ResourceAccessCheckerInterface $resourceAccessChecker = null,
         array $defaultContext = [],
         ?TagCollectorInterface $tagCollector = null,
-        private AbstractItemNormalizer $decorated,
+        private ?AbstractItemNormalizer $decorated = null,
     ) {
         parent::__construct(
             $propertyNameCollectionFactory,
@@ -93,4 +95,13 @@ public function supportsDenormalization(
 
         return $this->decorated->supportsDenormalization($data, $type, $format, $context);
     }
+
+    public function setSerializer(SerializerInterface $serializer): void
+    {
+        parent::setSerializer($serializer);
+
+        if ($this->decorated instanceof SerializerAwareInterface) {
+            $this->decorated->setSerializer($serializer);
+        }
+    }
 }

tests/Unit/Serializer/ExportAwareItemNormalizerTest.php

@@ -0,0 +1,46 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\ImportExport\Tests\Unit\Serializer;
+
+use ApiPlatform\Metadata\IriConverterInterface;
+use ApiPlatform\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
+use ApiPlatform\Metadata\Property\Factory\PropertyNameCollectionFactoryInterface;
+use ApiPlatform\Metadata\ResourceClassResolverInterface;
+use ApiPlatform\Serializer\AbstractItemNormalizer;
+use PHPUnit\Framework\TestCase;
+use Sylius\ImportExport\Serializer\ExportAwareItemNormalizer;
+use Symfony\Component\Serializer\SerializerInterface;
+
+final class ExportAwareItemNormalizerTest extends TestCase
+{
+    public function testSetSerializerPropagatesToDecoratedService(): void
+    {
+        $decorated = $this->createMock(AbstractItemNormalizer::class);
+        $serializer = $this->createMock(SerializerInterface::class);
+
+        $decorated->expects($this->once())
+            ->method('setSerializer')
+            ->with($serializer);
+
+        $normalizer = new ExportAwareItemNormalizer(
+            propertyNameCollectionFactory: $this->createMock(PropertyNameCollectionFactoryInterface::class),
+            propertyMetadataFactory: $this->createMock(PropertyMetadataFactoryInterface::class),
+            iriConverter: $this->createMock(IriConverterInterface::class),
+            resourceClassResolver: $this->createMock(ResourceClassResolverInterface::class),
+            decorated: $decorated,
+        );
+
+        $normalizer->setSerializer($serializer);
+    }
+}